Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wordPattern for XML and XSL languages #127334

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

datho7561
Copy link
Contributor

Add a wordPattern for XML and XSL, so that when linkedEditing is used, it can edit tags that have hyphens in their name.

I based the wordPattern off of https://www.w3.org/TR/xml/#NT-Name.

Signed-off-by: David Thompson davthomp@redhat.com

This PR fixes #127323

@ghost
Copy link

ghost commented Jun 28, 2021

CLA assistant check
All CLA requirements met.

@datho7561 datho7561 marked this pull request as ready for review June 28, 2021 15:12
Closes microsoft#127323

Signed-off-by: David Thompson <davthomp@redhat.com>
@aeschli aeschli added this to the June 2021 milestone Jun 29, 2021
@aeschli aeschli added bug Issue identified by VS Code Team member as probable bug languages-basic Basic language support issues labels Jun 29, 2021
@aeschli aeschli merged commit 28383a3 into microsoft:main Jun 29, 2021
@datho7561 datho7561 deleted the 127323-xml-word-pattern branch June 29, 2021 12:14
@jrieken jrieken added the verified Verification succeeded label Jul 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2021
@aeschli
Copy link
Contributor

aeschli commented May 12, 2022

FYI we made a change to the word pattern in #149369
The word pattern i not just for tag names, but also words in the content. So we can't restrict it to only the letters that can be in a tag. But we will add the - to it for #127323

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug languages-basic Basic language support issues verified Verification succeeded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linked editing with text containing a hyphen does not work in XML
3 participants