Allow showing intellisense without pre-selected item

[avneraa]

In Kusto we have a desktop tool (http://aka.ms/ke) using Dev Express libraries where the IntelliSense does not pre-select any of the items, and any key that is not alphanumeric dismisses the IntelliSense without committing anything. We find this behavior much more intuitive and friendly for authoring Kusto queries.

Here is an example of the two behaviors:

In Kusto explorer, hitting enter or any other key will dismiss the intellisense:

While in Monaco hitting enter will commit the “and” requiring the user to either hit escape of delete the committed text:

Thanks Avner Aharoni

[lidermanrony]

A finer point to note is that in Kusto desktop tool, if intellisense was triggered by the user, the value is preselected.
Only if the intellisense is triggered programmatically it is not preselected.

so we need to have this mode only when calling editor.trigger (somehow need to have this as a parameter to the call

editor.trigger('monaco-kusto', 'editor.action.triggerSuggest', {})

[jrieken]

Let's use June to figure out how this should work and how this should be done. Might also be interesting to explore if inline completions (aka ghost text) can be used here

[jrieken]

• add argument to editor.action.triggerSuggest to have suggest widget without selection @jrieken
• optional play with inline completion for optional kusto compltion @avneraa

[jrieken]

fyi @lidermanrony lastest bits in main support a noSelection-argument, e.g with editor.trigger('monaco-kusto', 'editor.action.triggerSuggest', { noSelection: true }) you should be able to trigger suggest without an (initial) selection

[jrieken]

@lidermanrony @avneraa do those changes work for you? Did we reach happyness?

[gjsjohnmurray]

Sort of related to this, can #85768 be reconsidered? It didn't get enough upvotes when a Backlog Candidate a couple of years ago.

[gil-koifman]

Hi,
We want to to have this noSelection option whenever the user is pressing the "triggerCharacters" in the CompletionProvider.
Lets say the trigger character is a space character, then we want to be able to configure that after pressing the space character, and showing the completion items, then there will be nothing selected by default.
But if the user has started typing, or is in the middle of the word, then we do want the best option to be preselected.

Is it possible to expose us this kind of mode?
Thanks!

[avneraa]

Awesome Gil! From: gil-koifman ***@***.***> Sent: Thursday, November 3, 2022 10:02 AM To: microsoft/vscode ***@***.***> Cc: Avner Aharoni ***@***.***>; Mention ***@***.***> Subject: Re: [microsoft/vscode] Allow showing intellisense without pre-selected item (Issue #151336) Hi, We want to to have this noSelection option whenever the user is pressing the "triggerCharacters" in the CompletionProvider. Lets say the trigger character is a space character, then we want to be able to configure that after pressing the space character, and showing the completion items, then there will be nothing selected by default. But if the user has started typing, or is in the middle of the word, then we do want the best option to be preselected. Is it possible to expose us this kind of mode? Thanks! - Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fvscode%2Fissues%2F151336%23issuecomment-1301754510&data=05%7C01%7Cavnera%40microsoft.com%7C2c7a3e68bfdb410294af08dabd71bcfc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638030593467802567%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=bTwB2BBJG12ZoO%2Bz%2FB3kKHE%2F1vgNjw1H2i8LUKaVKTE%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABAQQRXJJBJ7YPVK7BO25I3WGNWQ5ANCNFSM5X7KJ7QA&data=05%7C01%7Cavnera%40microsoft.com%7C2c7a3e68bfdb410294af08dabd71bcfc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638030593467959246%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=FWXH%2BwaQtfQ6z1b1UMwvGbjZO%2BQk%2B8FDrr49EspOGNg%3D&reserved=0>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>

[jrieken]

@gil-koifman @avneraa Just to clarify: assuming this is an editor option (noSelectOnTriggerCharacter and noSelectOnQuickSuggest) would you still need the noSelection argument (#151336 (comment)) or can I remove that again?

[gil-koifman]

@jrieken That depends.. Will "noSelectOnQuickSuggest" take care of this for us? We do still need the ability to manually trigger the completion list using the trigger "editor.action.triggerSuggest", and have the no selection capability with it.

[jrieken]

Yeah, should still be possible. The editor.action.triggerSuggest command accepts an auto-flag which will tell it to act as if quick suggest is on

[jrieken]

Sort of related to this, can #85768 be reconsidered? It didn't get enough upvotes when a Backlog Candidate a couple of years ago.

@gjsjohnmurray Will be similar but not a selection mode. It will be an option that's only applicable for auto-suggest (quick suggest and trigger characters)

[jrieken]

This is done and behind the (non documented) editor.suggest.selectQuickSuggestions options. fyi @avneraa @gil-koifman

[jrieken]

To verify

• set the setting editor.suggest.selectQuickSuggestions: false
• trigger suggest manually (ctrl+space) and make sure there is a focused suggestion
• trigger suggest automatically, via typing or via trigger character, and make sure no suggested is focused. press ctrl+space again and ensure a suggestion is now focused

[gil-koifman]

@jrieken
Hey, thanks for this change, I verified and it worked.
There is a tweak though that is missing for our requirement:
If the user pressed the "triggerCharacters", in our case it's "space", then when the suggestion list shows - nothing will be selected. This is implemented in your solution.
But if the user started typing something, or started deleting characters from an existing word, then we do want the first option to be selected. In the above solution, nothing will be selected.

[isidorn]

Works as expected -> verified.
However the setting is hidden, it can not be discovered by the users. @jrieken is this expected?

[jrieken]

it can not be discovered by the users. @jrieken is this expected?

Yeah, for now it is just a monaco editor thing

[jrieken]

But if the user started typing something, or started deleting characters from an existing word, then we do want the first option to be selected. In the above solution, nothing will be selected.

@gil-koifman Can you please create a new issue for that. Thanks