"selectQuickSuggestions: off" behavior change request

[gil-koifman]

Hi,
This request is a follow up for the issue:
#151336

We would like to have selectQuickSuggestions turned off, but with a small behavior change.
If the user pressed the "triggerCharacters", in our case it's "space", then when the suggestion list shows - nothing will be selected. This is implemented today with turning off selectQuickSuggestions.
But if the user started typing something, or started deleting characters from an existing word, then we do want the first option to be selected. In the current behavior, nothing will be selected.

Thanks!

[jrieken]

To clarify: like we differentiate between trigger editor.suggestOnTriggerCharacters and editor.quickSuggestions you like to be able to configure select mode for each of these auto-modes independently, right?

So, don't have editor.suggest.selectQuickSuggestions as true|false but as onTriggerCharacter | onQuickSuggest | always | never

[jrieken]

As discussed offline, this is now implemented with a revised setting: editor.suggest.selectionMode. demo: #139825 (comment)

[gil-koifman]

Looks great! Thank you.

[jrieken]

Thanks for catching up.

[jrieken]

test plan covered by #171988