Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to hide menu items #154804

Closed
jrieken opened this issue Jul 11, 2022 · 3 comments
Closed

Ability to hide menu items #154804

jrieken opened this issue Jul 11, 2022 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality menus Menu items and widget issues on-testplan

Comments

@jrieken
Copy link
Member

jrieken commented Jul 11, 2022

This is a (small) step towards #9285 and about be able to hide/re-show menu items from toolbars. Very similar to how it works with view headers or the activity bar. This isn't about rearranging items, changing the conditions under which they show, or a textual configuration format (like keybindings.json)

@jrieken jrieken self-assigned this Jul 11, 2022
@jrieken jrieken added feature-request Request for new features or functionality menus Menu items and widget issues labels Jul 11, 2022
@jrieken jrieken added this to the Backlog milestone Jul 11, 2022
@jrieken
Copy link
Member Author

jrieken commented Jul 11, 2022

Happening here: #154801

@jrieken
Copy link
Member Author

jrieken commented Jul 21, 2022

We have explored this but aren't happy with the current solution. Because vacation times are started I will pull out the feature again and make it proper in August/September.

jrieken added a commit that referenced this issue Jul 21, 2022
this removes how hiding is currently done but also refactorings the internal into a better shape so that this can be picked up again

#154804
jrieken added a commit that referenced this issue Jul 21, 2022
this removes how hiding is currently done but also refactorings the internal into a better shape so that this can be picked up again

#154804
@jrieken jrieken modified the milestones: August 2022, September 2022 Aug 24, 2022
@jrieken jrieken closed this as completed Sep 20, 2022
@jrieken
Copy link
Member Author

jrieken commented Sep 20, 2022

This is now done. You can right-click toolbar items to hide them. They either move into the overflow menu or hide completely. There is a global "Reset hidden menus" command and an optional "Reset Menu" context command

@jrieken jrieken mentioned this issue Sep 26, 2022
2 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality menus Menu items and widget issues on-testplan
Projects
None yet
Development

No branches or pull requests

1 participant