joh/notebook toolbar #161098
Merged
joh/notebook toolbar #161098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecause some custom action things are going on
@roblourens this removes listening and rebuilding the menu when `insertToolbarAlignment` changes. This might be wrong but I couldn't get see how that event relates to the number of menu items (which are context key driven) use `WorkbenchToolBar` in CellTitleToolbarPart, doesn't use `MenuWorkbenchToolBar` because of `updateAction` things
This reverts commit fa89b71.
…mAction, e.g the `...` button
jrieken
commented
Sep 16, 2022
| this._toolbar.setActions(actions); | ||
| menu.dispose(); |
There was a problem hiding this comment.
I changed this to be a local because I don't see any other references and disposing a menu quickly is better - since it stops listening on CKS events
jrieken
commented
Sep 16, 2022
| @@ -40,6 +40,7 @@ export class RunToolbar extends CellPart { | |||
|
|
|||
| const menu = this._register(menuService.createMenu(this.notebookEditor.creationOptions.menuIds.cellExecutePrimary!, contextKeyService)); | |||
| const secondaryMenu = this._register(menuService.createMenu(this.notebookEditor.creationOptions.menuIds.cellExecuteToolbar, contextKeyService)); | |||
| // TODO@roblourens what does secondaryMenu actually do? where/when is it rendered? | |||
There was a problem hiding this comment.
@roblourens wasn't sure what this secondaryMenu is about. It's like not needed, right?
There was a problem hiding this comment.
This is the dropdown for the run button (has Debug Cell). For some reason I create that menu again here:
I think that's the result of refactoring, I'll clean it up after your PR is merged.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #154804
We now have
WorkbenchToolBarandMenuWorkbenchToolBar. The latter is better/simpler but a little harder to adopt. This PR is about adopting each in notebook land. This will brings the ability to right click an item and hide it.I couldn't get this to work with notebook title toolbar. There must be some extra filtering that I didn't understand... Some work is left but I leave it to @roblourens or @rebornix
MenuWorkbenchToolBarin interactive editorWorkbenchToolBarin cellOutput but notMenuWorkbenchToolBarbecause some custom action things are going onMenuWorkbenchToolBarin BetweenCellToolBarWorkbenchToolBarin codeCellRunToolbarWorkbenchToolBarin notebook editor toolbarWorkbenchToolBarin notebook diff landWorkbenchToolBarin notebook editor toolbar"...button