-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminal: Underline with canvas uses less spacing #158874
Labels
bug
Issue identified by VS Code Team member as probable bug
insiders-released
Patch has been released in VS Code Insiders
terminal-rendering
upstream
Issue identified as 'upstream' component related (exists outside of VS Code)
upstream-issue-fixed
The underlying upstream issue has been fixed
upstream-issue-linked
This is an upstream issue that has been reported upstream
verified
Verification succeeded
Milestone
Comments
Tyriar
added
bug
Issue identified by VS Code Team member as probable bug
upstream
Issue identified as 'upstream' component related (exists outside of VS Code)
upstream-issue-linked
This is an upstream issue that has been reported upstream
terminal-rendering
labels
Aug 23, 2022
Upstream: xtermjs/xterm.js#4058 |
Tyriar
added a commit
that referenced
this issue
Oct 6, 2022
- Bump copyright year xtermjs/xterm.js#4176 - Share texture atlas cache code between webgl and canvas renderers xtermjs/xterm.js#4170 - Add willReadFrequently to canvas renderer too xtermjs/xterm.js#4169 - Ensure texture atlas comparison uses rgba not object xtermjs/xterm.js#4168 - Create new event with emitter object to simplify code xtermjs/xterm.js#4166 - Define all events and emitters consistently xtermjs/xterm.js#4165 - Inline dirty row service into input handler xtermjs/xterm.js#4163 - Move w objects to $ prefix variables xtermjs/xterm.js#4162 Fixes #158984 Fixes #158874
Merged
Tyriar
added
the
upstream-issue-fixed
The underlying upstream issue has been fixed
label
Oct 6, 2022
VSCodeTriageBot
added
unreleased
Patch has not yet been released in VS Code Insiders
insiders-released
Patch has been released in VS Code Insiders
and removed
unreleased
Patch has not yet been released in VS Code Insiders
labels
Oct 6, 2022
lemanschik
pushed a commit
to code-oss-dev/code
that referenced
this issue
Nov 25, 2022
- Bump copyright year xtermjs/xterm.js#4176 - Share texture atlas cache code between webgl and canvas renderers xtermjs/xterm.js#4170 - Add willReadFrequently to canvas renderer too xtermjs/xterm.js#4169 - Ensure texture atlas comparison uses rgba not object xtermjs/xterm.js#4168 - Create new event with emitter object to simplify code xtermjs/xterm.js#4166 - Define all events and emitters consistently xtermjs/xterm.js#4165 - Inline dirty row service into input handler xtermjs/xterm.js#4163 - Move w objects to $ prefix variables xtermjs/xterm.js#4162 Fixes microsoft#158984 Fixes microsoft#158874
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bug
Issue identified by VS Code Team member as probable bug
insiders-released
Patch has been released in VS Code Insiders
terminal-rendering
upstream
Issue identified as 'upstream' component related (exists outside of VS Code)
upstream-issue-fixed
The underlying upstream issue has been fixed
upstream-issue-linked
This is an upstream issue that has been reported upstream
verified
Verification succeeded
Testing #158827
Version: 1.71.0-insider
Commit: bd61073
Date: 2022-08-23T05:19:02.563Z
Electron: 19.0.12
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Darwin x64 21.6.0
Sandboxed: Yes
terminal.integrated.gpuAcceleration: canvas
terminal.integrated.gpuAcceleration: on
Note that the spacing of the underline differs: with canvas it is a bit too close to the text
The text was updated successfully, but these errors were encountered: