Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share texture atlas cache code between webgl and canvas renderers #4170

Merged
merged 26 commits into from
Oct 5, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Oct 2, 2022

Fixes #4065
Fixes #4062
Fixes #4058

@Tyriar Tyriar added this to the 5.1.0 milestone Oct 2, 2022
@Tyriar Tyriar self-assigned this Oct 2, 2022
@Tyriar Tyriar marked this pull request as ready for review October 4, 2022 22:25
@Tyriar Tyriar merged commit aa55d1b into xtermjs:master Oct 5, 2022
@Tyriar Tyriar deleted the shared_cache branch October 5, 2022 17:20
Tyriar added a commit to microsoft/vscode that referenced this pull request Oct 6, 2022
- Bump copyright year xtermjs/xterm.js#4176
- Share texture atlas cache code between webgl and canvas renderers xtermjs/xterm.js#4170
- Add willReadFrequently to canvas renderer too xtermjs/xterm.js#4169
- Ensure texture atlas comparison uses rgba not object xtermjs/xterm.js#4168
- Create new event with emitter object to simplify code xtermjs/xterm.js#4166
- Define all events and emitters consistently xtermjs/xterm.js#4165
- Inline dirty row service into input handler xtermjs/xterm.js#4163
- Move w objects to $ prefix variables xtermjs/xterm.js#4162

Fixes #158984
Fixes #158874
lemanschik pushed a commit to code-oss-dev/code that referenced this pull request Nov 25, 2022
- Bump copyright year xtermjs/xterm.js#4176
- Share texture atlas cache code between webgl and canvas renderers xtermjs/xterm.js#4170
- Add willReadFrequently to canvas renderer too xtermjs/xterm.js#4169
- Ensure texture atlas comparison uses rgba not object xtermjs/xterm.js#4168
- Create new event with emitter object to simplify code xtermjs/xterm.js#4166
- Define all events and emitters consistently xtermjs/xterm.js#4165
- Inline dirty row service into input handler xtermjs/xterm.js#4163
- Move w objects to $ prefix variables xtermjs/xterm.js#4162

Fixes microsoft#158984
Fixes microsoft#158874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant