Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package.json browser field cannot be converted in acquireWebNodePaths #165162

Closed
yiliang114 opened this issue Nov 1, 2022 · 1 comment · Fixed by #165163
Closed

package.json browser field cannot be converted in acquireWebNodePaths #165162

yiliang114 opened this issue Nov 1, 2022 · 1 comment · Fixed by #165163
Assignees
@lramos15
Labels
engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue
Milestone
November 2022

Comments

@yiliang114
Copy link
Contributor

Does this issue occur when all extensions are disabled?: Yes.

In the fact, this problem is not encountered in actual use, but a bug encountered when I tried to modify VS Code.

  • VS Code Version: 1.73.0 be022da
  • OS Version: Macos 12.2.1 Intel

Steps to Reproduce:

  1. Clone VS Code source code
  2. yarn install
  3. Add dependencies to remote/web/package.json.For example, add react-dom to simulate scenarios where dependencies need to be added to vscode-web., then yarn add react-dom under the root directory.
  4. Use cmd + shift + B shortcut keys to perform Core - Build and Ext - Build tasks. Then you will find that the mission unexpectedly quit.

image

  1. The problem is that browser fields can be not only string but also objects.

image

image
@VSCodeTriageBot
Copy link
Collaborator

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.72.2. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

yiliang114 added a commit to yiliang114/vscode that referenced this issue Nov 1, 2022
@yiliang114
fix(build): Close microsoft#165162, only use string of the package.js…
2f4e9cc 
…on `browser` field
@yiliang114 yiliang114 mentioned this issue Nov 1, 2022
Merged
@aeschli aeschli assigned lramos15 and unassigned aeschli Nov 1, 2022
@lramos15 lramos15 added polish Cleanup and polish issue engineering VS Code - Build / issue tracking / etc. labels Nov 2, 2022
lramos15 pushed a commit that referenced this issue Nov 8, 2022
@yiliang114
Only use string of the remote/web/package.json browser field (#16…
59faab4 
…5163)

fix(build): Close #165162, only use string of the package.json `browser` field
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Nov 8, 2022
@VSCodeTriageBot VSCodeTriageBot added this to the November 2022 milestone Nov 8, 2022
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lramos15 lramos15

Labels
engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue
Projects
None yet
Milestone
November 2022
Development

Successfully merging a pull request may close this issue.

Only use string of the remote/web/package.json browser field yiliang114/vscode
4 participants
@lramos15 @aeschli @yiliang114 @VSCodeTriageBot