Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use string of the remote/web/package.json browser field #165163

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

yiliang114
Copy link
Contributor

Close #165162. I think it is possible to simply ignore the situation where the browser is an object.

@aeschli aeschli assigned lramos15 and unassigned aeschli Nov 1, 2022
@yiliang114
Copy link
Contributor Author

hi @joaomoreno , Can you help me review this PR?

@lramos15 lramos15 merged commit 59faab4 into microsoft:main Nov 8, 2022
@aeschli aeschli added this to the November 2022 milestone Dec 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package.json browser field cannot be converted in acquireWebNodePaths
4 participants