Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate moving away from the styler pattern #165478

Closed
alexdima opened this issue Nov 4, 2022 · 3 comments
Closed

Investigate moving away from the styler pattern #165478

alexdima opened this issue Nov 4, 2022 · 3 comments
Assignees
Labels
editor-theming Issues related to the way themes are applied to editors feature-request Request for new features or functionality plan-item VS Code - planned item for upcoming verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@alexdima
Copy link
Member

alexdima commented Nov 4, 2022

Having more styling be done via CSS would reduce the amount of JS code we need to ship and run. We should investigate if it is possible to achieve the same composition as we do today in JS, by using CSS variables. We should also check that this doesn't cause any performance problems and that it is idiomatic CSS

/* in base widget CSS */
.monaco-inputbox {
    --monaco-inputbox-foreground: #CCCCCC;
}
.monaco-inputbox {
    position: relative;
    display: block;
    padding: 0;
    box-sizing: border-box;
    border-radius: 2px;
    /* Customizable */
    font-size: inherit;
    color: var(--monaco-inputbox-foreground)
}

/* in widget user CSS */
.findWidget .monaco-inputbox {
    --monaco-inputbox-foreground: var(--vscode-find-widget-input);
}
@aeschli
Copy link
Contributor

aeschli commented Nov 28, 2022

Half of the stylers have been converted, still more to do.

@aeschli aeschli modified the milestones: November 2022, December 2022 Nov 28, 2022
@aeschli aeschli added feature-request Request for new features or functionality editor-theming Issues related to the way themes are applied to editors labels Dec 15, 2022
@aeschli
Copy link
Contributor

aeschli commented Jan 23, 2023

All stylers replaced

@aeschli aeschli closed this as completed Jan 23, 2023
@aeschli aeschli added the verification-needed Verification of issue is requested label Jan 23, 2023
@aeschli
Copy link
Contributor

aeschli commented Jan 23, 2023

Verify in source that there is no more styler.ts

@jrieken jrieken added the verified Verification succeeded label Jan 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-theming Issues related to the way themes are applied to editors feature-request Request for new features or functionality plan-item VS Code - planned item for upcoming verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants