Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

menu: move away from styler #169748

Merged
merged 2 commits into from
Jan 18, 2023
Merged

menu: move away from styler #169748

merged 2 commits into from
Jan 18, 2023

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented Dec 21, 2022 •
edited
Loading

For #165478

Make consistent with other widgets:

  • Styles come in in constructor. Can be a variable
  • parameter and properties are not optional so that API users don't forget to think about it.

@aeschli aeschli enabled auto-merge (squash) December 21, 2022 14:22
@aeschli aeschli self-assigned this Dec 21, 2022
@aeschli aeschli requested a review from sbatten December 21, 2022 14:22
@aeschli aeschli added this to the January 2023 milestone Dec 21, 2022
@aeschli aeschli added the themes Color theme issues label Dec 21, 2022
@aeschli
Copy link
Contributor Author

aeschli commented Jan 18, 2023

@sbatten Can you have look as this is in your area?

@aeschli aeschli merged commit 5690bc4 into main Jan 18, 2023
@aeschli aeschli deleted the aeschli/menuRemoveStyler branch January 18, 2023 18:57
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbatten sbatten sbatten approved these changes

Assignees

@aeschli aeschli

Labels
themes Color theme issues
Projects
None yet
Milestone
January 2023
Development

Successfully merging this pull request may close these issues.
2 participants
@aeschli @sbatten