-
Notifications
You must be signed in to change notification settings - Fork 29.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow FileSystemProviders to set the read-only file message #166971
Labels
Milestone
Comments
Proposal ( vscode/src/vscode-dts/vscode.proposed.readonlyMessage.d.ts Lines 10 to 13 in dbb7f45
|
This was referenced Jun 16, 2023
alexr00
added a commit
to microsoft/vscode-pull-request-github
that referenced
this issue
Jun 16, 2023
alexr00
added a commit
that referenced
this issue
Jun 21, 2023
* wip * Allow extensions to provide a readonly message Part of #166971 * Address feedback * Further address feedback * Fix some nits * Add test * Improve tests and respond to feedback * Don't render editor.readOnlyMessage in the settings UI * No need to validate the IMarkdownString --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> Co-authored-by: Alex Dima <alexdima@microsoft.com>
alexr00
added a commit
to microsoft/vscode-pull-request-github
that referenced
this issue
Jun 22, 2023
* Add read-only message for unchecked out PR files Part of microsoft/vscode#166971 * Update readonly message
2 tasks
alexr00
added a commit
that referenced
this issue
Jan 11, 2024
alexr00
added a commit
that referenced
this issue
Jan 11, 2024
Finalize read-only message file system provider API Part of #166971
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
In the GitHub Pull Request and Issues extension, we show PR diffs using a
FileSystemProvider
and make them read-only when the PR is not checked out. This makes sense since the file is not available on the local system, so there's nothing there to edit.However, users want to edit these files and are confused when they get the "Cannot edit in read-only editor" message when they start typing (microsoft/vscode-pull-request-github#3450)
I'd like to encourage users to check out the PR when they try to edit these read-only files. One option to do this would be to change the "Cannot edit in read-only editor" message to "Checkout the pull request to edit this file", or even better to have a markdown popup that shows so I can actually give them a link to check out the PR.
To that end, maybe
isReadonly
, could take a string or, even better, a markdown string:vscode/src/vscode-dts/vscode.d.ts
Lines 12613 to 12614 in 94ee5f5
The text was updated successfully, but these errors were encountered: