Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set a read-only message from an extension #185216

Merged
merged 10 commits into from
Jun 21, 2023
Merged

Set a read-only message from an extension #185216

merged 10 commits into from
Jun 21, 2023

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Jun 15, 2023

Part of #166971

@alexr00 alexr00 self-assigned this Jun 15, 2023
@alexr00 alexr00 requested review from alexdima and bpasero June 15, 2023 12:35
@vscodenpa vscodenpa added this to the June 2023 milestone Jun 15, 2023
@alexr00
Copy link
Member Author

alexr00 commented Jun 15, 2023

The fade out animation has started, but here's a screenshot:

image

bpasero
bpasero requested changes Jun 16, 2023
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, I especially like the idea of allowing boolean | MarkdownString to avoid introducing a second method for this.

src/vs/workbench/contrib/files/common/explorerModel.ts Show resolved Hide resolved
src/vs/workbench/common/editor/editorInput.ts Outdated Show resolved Hide resolved
src/vs/workbench/services/workingCopy/common/storedFileWorkingCopy.ts Outdated Show resolved Hide resolved
src/vs/workbench/browser/parts/editor/textDiffEditor.ts Outdated Show resolved Hide resolved
@alexr00 alexr00 requested review from bpasero and removed request for alexdima June 16, 2023 06:55
@alexr00 alexr00 mentioned this pull request Jun 16, 2023
Closed
@alexr00 alexr00 requested review from alexdima and bpasero and removed request for bpasero June 16, 2023 10:38
bpasero
bpasero requested changes Jun 16, 2023
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, only some minor feedback.

src/vs/workbench/contrib/files/browser/editors/fileEditorInput.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/notebook/common/notebookEditorModel.ts Outdated Show resolved Hide resolved
src/vs/workbench/browser/parts/editor/textEditor.ts Outdated Show resolved Hide resolved
src/vscode-dts/vscode.proposed.readonlyMessage.d.ts Show resolved Hide resolved
@alexr00 alexr00 requested review from alexdima and bpasero and removed request for alexdima June 19, 2023 10:10
@alexr00 alexr00 added git GIT issues and removed git GIT issues labels Jun 19, 2023
bpasero
bpasero previously approved these changes Jun 19, 2023
View reviewed changes
alexdima
alexdima approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bpasero bpasero self-requested a review June 21, 2023 08:54
@alexr00 alexr00 merged commit 1a4e466 into main Jun 21, 2023
@alexr00 alexr00 deleted the alexr00/readonlyMessage branch June 21, 2023 08:55
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexdima alexdima alexdima approved these changes

@bpasero bpasero bpasero approved these changes

Assignees

@alexr00 alexr00

Labels
None yet
Projects
None yet
Milestone
June 2023
Development

Successfully merging this pull request may close these issues.
4 participants
@alexr00 @bpasero @alexdima @vscodenpa