Intellisense dismisses inline completions even if intellisense selected item and inline completion prefix match

[juihanamshet1]

Does this issue occur when all extensions are disabled?: Yes/No

• VS Code Version: 1.74.2
• OS Version:

Steps to Reproduce:

1. Use the project in https://github.com/microsoft/vscode-extension-samples/tree/main/inline-completions. In the extension.ts, enable completeBracketPairs.
   

2. Run the project

3. Open an empty .ts file and type [0,*):if (var) {

4. When you hit Enter, the prediction you see on the screen will be [0,*):if (var) {}. Note the curly brace is closed.

5. Now type along the prediction, when you type v, Intellisense will select var but despite this, the prediction gets dismissed. The expected behavior is that inline prediction stays because Intellisense item is the same.
   

6. This bug happens specifically when there are brackets are autoclosed by completeBracketPairs. I investigated further and noticed this condition was returning false. For the above example, the augmentedCompletion.range was [4,6]->[4,7] whereas the suggestInlineCompletion.range was [4,6]->[4,6].
   My suspicion for why augmentedCompletion.range was ending with [4,7] was that it's because 1 brace was added by completeBracketPairs, the range is incremented by 1. But even if completeBracketPairs adds 2 braces, the range remains [4,7].

cc @hediet

[juihanamshet1]

You want these two internal settings enabled in settings.json btw
"editor.inlineSuggest.allowQuickSuggestions": true,
"editor.inlineSuggest.allowSuggestOnTriggerCharacters": true,

[juihanamshet1]

I did some more investigation.
The augmentedCompletion.range was ending with [4,7] because the buffer text was if (v) so that makes sense.

I noticed another place where the augmentedCompletion.range.equalsRange(suggestInlineCompletion.range) causes an issue

console is in the Intellisense menu but doesn't get preselected. Here, the augmentedCompletion.range is [2,1] -> [2,6] whereas the suggestInlineCompletion.range was [2,6] -> [2,6].

[ayim]

Hey folks, happy new year.
Checking in here to help with planning on our end - @hediet are we in a spot to say whether this will make it in for Jan 2023 iteration? It's the last issue before we go to market.

-A

[ayim]

As per convo between Henning & Jui: the behaviour will be redesigned, this issue hasn't been looked at yet:

#172029

[hediet]

This particular situation was not supported before, also the docs stated that this wouldn't work.

Anyway, I changed it sligthly so that this case should work now. I also fixed some other issues (regarding suggest widget preselection).

[rzhao271]

1. Set editor.inlineSuggest.enabled to true, and set the settings listed in Intellisense dismisses inline completions even if intellisense selected item and inline completion prefix match #170527 (comment) in the user settings JSON file, because they don't show up in the Settings editor.
2. Use the inline completions sample extension from vscode-extension-samples. I had to made sure the extension sample was using the proposed inlineCompletionsAdditions API and use npx vscode-dts dev and npx vscode-dts main to fetch the newest APIs.
3. Run the extension.
4. Create a new ts file and type // [0,*):if (var) {. Press enter, and an inline completion should show up.
5. Type if (v. 🐛 The inline completion collapses.

[juihanamshet1]

I ran the repro steps in the latest Insiders
Version: 1.75.0-insider (user setup)
Commit: b229eb5
Date: 2023-01-27T22:17:10.413Z

The bug that I had initially reported seems to have been fixed however, it didn't fix the problem entirely.

When I type v, inline and intellisense stay but when I finish typing var, inline gets dismissed.

[juihanamshet1]

This particular situation was not supported before, also the docs stated that this wouldn't work.

Anyway, I changed it sligthly so that this case should work now. I also fixed some other issues (regarding suggest widget preselection).

@hediet The case of "when inline completion is on the screen and the user overtypes, intellisense should show with the prefix of the inline completion pre-selected in intellisense" is supported by the two hidden settings ("editor.inlineSuggest.allowQuickSuggestions": true, "editor.inlineSuggest.allowSuggestOnTriggerCharacters": true). The bug I filed is a subset of this.

[hediet]

Can be reproduced in the playground:

Fixed in upcoming version (just select the newest version in the playground):

[TylerLeonhardt]

looks correct to me!