Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependencies in rpm package #17142

Closed
Tyriar opened this issue Dec 13, 2016 · 13 comments · Fixed by #17150 or #143415
Closed

Missing dependencies in rpm package #17142

Tyriar opened this issue Dec 13, 2016 · 13 comments · Fixed by #17150 or #143415
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders install-update VS Code installation and upgrade system issues linux Issues with VS Code on Linux on-testplan
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 13, 2016

#13089 but for .rpm

Notes:

@Tyriar Tyriar added debt Code quality issues install-update VS Code installation and upgrade system issues linux Issues with VS Code on Linux labels Dec 13, 2016
@Tyriar Tyriar added this to the January 2017 milestone Dec 13, 2016
@Tyriar Tyriar self-assigned this Dec 13, 2016
Tyriar added a commit that referenced this issue Dec 14, 2016
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Dec 14, 2016
@Tyriar
Copy link
Member Author

Tyriar commented Dec 14, 2016

To verifier: Please verify installation works fine on both a 32-bit and 64-bit CentOS (I tested using Fedora when implementing).

@chrmarti
Copy link
Contributor

@Tyriar Seeing this on CentOS 8.6 64-bit live CD:

screen shot 2017-01-27 at 2 41 55 pm

@chrmarti chrmarti reopened this Jan 27, 2017
@chrmarti
Copy link
Contributor

screen shot 2017-01-27 at 2 45 32 pm

@chrmarti chrmarti added the verification-found Issue verification failed label Jan 27, 2017
@Tyriar Tyriar modified the milestones: February 2017, January 2017 Jan 27, 2017
@Tyriar Tyriar removed the verification-found Issue verification failed label Jan 27, 2017
@chrmarti
Copy link
Contributor

Consistently so for the 32-bit version:

CentOS 8.6 32-bit live CD:
screen shot 2017-01-27 at 2 59 34 pm

screen shot 2017-01-27 at 3 00 47 pm

@chrmarti
Copy link
Contributor

CentOS 7 build 1611 64-bit live DVD installs the package, but the crashes on startup of VSCode. --verbose shows:
screen shot 2017-01-27 at 3 14 56 pm

And:
screen shot 2017-01-27 at 3 15 58 pm

Changing the permissions as asked for fixed the problem. Not sure if there is a way to avoid that, but other applications don't seem to require that change in permissions.

@Tyriar Tyriar modified the milestones: February 2017, Backlog Feb 21, 2017
@bpasero bpasero removed the verification-needed Verification of issue is requested label Feb 25, 2017
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities and removed debt Code quality issues labels Oct 9, 2019
@mMerlin
Copy link

mMerlin commented Dec 7, 2019

Amend that only libX11-xcb. That was enough to get vscode to run, but further usage encountered errors about no icu package on the system. Installing libicu seems to have cleared that up.

@joaomoreno
Copy link
Member

@Tyriar @deepak1556 Can we close this?

@deepak1556
Copy link
Collaborator

I haven't looked into this recently but I think we should be good on this. Something I like to eventually setup is a way to update the dependency during runtime version updates.

@Tyriar
Copy link
Member Author

Tyriar commented Nov 5, 2021

This never got fixed and is still a problem afaik. Certain distros don't include some base deps and VS Code will install successfully but not launch without manually installing the deps it complains about.

@deepak1556
Copy link
Collaborator

@Tyriar is it only libX11-xcb mentioned in #17142 (comment) ? Do we need to validate the dependency list for the current runtime version ?

@Tyriar
Copy link
Member Author

Tyriar commented Nov 5, 2021

@deepak1556 I don't know how you get the dependency list for a binary but we need to do that and update it, I think there's some commands to do this. I think there's more than just libX11-xcb.

@mMerlin
Copy link

mMerlin commented Nov 5, 2021

In my case (2 years ago), libX11-xcb plus libicu were enough.

@rzhao271 rzhao271 self-assigned this Feb 18, 2022
@rzhao271 rzhao271 modified the milestones: Backlog, March 2022 Feb 18, 2022
@Tyriar Tyriar removed their assignment Mar 7, 2022
@rzhao271 rzhao271 added on-testplan and removed help wanted Issues identified as good community contribution opportunities labels Mar 21, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2022
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders install-update VS Code installation and upgrade system issues linux Issues with VS Code on Linux on-testplan
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

8 participants
@joaomoreno @bpasero @mMerlin @deepak1556 @Tyriar @rzhao271 @chrmarti and others