Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish RPM dependencies generator #147336

Merged
merged 5 commits into from
Apr 19, 2022
Merged

Conversation

rzhao271
Copy link
Contributor

Ref #17142

We used to have a hardcoded list of dependencies for the RPM package.
Then, I added a change that generates the rpm dependencies list per package CI run.
Now, I added some polish so that

  • We have a reference list of dependencies, which means the CI can now detect when the dependencies list has changed.
  • There is a constant that makes it relatively easy to switch between failing the build on new dependencies, and simply logging a warning.

@rzhao271 rzhao271 self-assigned this Apr 13, 2022
@rzhao271 rzhao271 added this to the April 2022 milestone Apr 13, 2022
@rzhao271
Copy link
Contributor Author

056d678ca2 CI package build is green

@deepak1556
Copy link
Collaborator

Which CI run was used to extract the dependencies list into build/linux/rpm/dep-lists.ts ?

@rzhao271
Copy link
Contributor Author

rzhao271 commented Apr 19, 2022

I manually copy-pasted from another run where I printed the dependencies:
Debian: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=166357&view=results
RPM: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=166793&view=results (it failed, but printed the dependencies before failing)

@deepak1556 deepak1556 merged commit 56fcb7c into main Apr 19, 2022
@deepak1556 deepak1556 deleted the rzhao271/rpm-dependencies-record branch April 19, 2022 15:33
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants