Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky scroll for terminal commands #172742

Closed
nickserv opened this issue Jan 30, 2023 · 6 comments · Fixed by #197558
Closed

Sticky scroll for terminal commands #172742

nickserv opened this issue Jan 30, 2023 · 6 comments · Fixed by #197558
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal-rendering terminal-shell-integration Shell integration, command decorations, etc.
Milestone

Comments

@nickserv
Copy link

nickserv commented Jan 30, 2023

Quoting @lunasorcery:

imagining a terminal emulator with sticky-scrolling, so if a command's output would push the command itself off the top of the screen, that command gets pinned to the top of the screen instead

This would bring VSCode's existing sticky scroll support to terminals for easier viewing and editing of commands with long outputs.

Suggested implementation

Use shell integration to track commands and render the currently scrolled output's command at the top of the editor in a sticky scroll if it doesn't fit on the screen.

Potential problems

If a command's output is larger than the terminal's buffer, its command may no longer exist. We may need to cache the last command if it's not already accessible by the shell integration.

Prior art

@sbatten sbatten assigned Tyriar and meganrogge and unassigned sbatten Jan 30, 2023
@meganrogge meganrogge added feature-request Request for new features or functionality terminal Integrated terminal issues labels Jan 30, 2023
@vscodenpa vscodenpa added this to the Backlog Candidates milestone Jan 30, 2023
@vscodenpa
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa
Copy link

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa
Copy link

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Apr 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2023
@Tyriar Tyriar reopened this Aug 1, 2023
@microsoft microsoft unlocked this conversation Aug 1, 2023
@Tyriar Tyriar modified the milestones: Backlog Candidates, Backlog Aug 1, 2023
@Tyriar Tyriar added terminal-rendering terminal-shell-integration Shell integration, command decorations, etc. and removed terminal Integrated terminal issues labels Aug 1, 2023
Tyriar added a commit that referenced this issue Aug 25, 2023
@Tyriar
Copy link
Member

Tyriar commented Aug 25, 2023

Put together a WIP prototype for this:

image

Branch: https://github.com/microsoft/vscode/tree/tyriar/172742_sticky_scroll

@tisilent
Copy link
Contributor

Can I give it a try.

@Tyriar
Copy link
Member

Tyriar commented Sep 18, 2023

@tisilent this one would be best done by me imo as it needs some iterating within the team and with ux designers

@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 8, 2023
@rzhao271 rzhao271 modified the milestones: On Deck, November 2023 Nov 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal-rendering terminal-shell-integration Shell integration, command decorations, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants