Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Terminal sticky scroll #199240

Closed
3 tasks done
Tyriar opened this issue Nov 27, 2023 · 0 comments
Closed
3 tasks done

Test: Terminal sticky scroll #199240

Tyriar opened this issue Nov 27, 2023 · 0 comments

Comments

@Tyriar
Copy link
Member

Tyriar commented Nov 27, 2023

Refs: #172742, #197735, #197736, #198224

Complexity: 4

Create Issue


Terminal sticky scroll is here, you can enable it via terminal.integrated.stickyScroll.enabled and configure the max lines via terminal.integrated.stickyScroll.maxLineCount. It should basically work the same as the editor, just the sticky part is the command that was run.

Screenshot 2023-11-27 at 14 22 31

Things to test:

  • That the sticky command is well formed in single line, multi-line and multi-line that start with a blank space prompt
  • It interacts with the scroll bar and overview ruler as expected
  • It doesn't obscure something it shouldn't
  • Run commands you typically use and make sure it works
  • The font matches the terminal exactly
  • The theme keys terminalStickyScroll.background, terminalStickyScrollHover.background work as expected
@Tyriar Tyriar added this to the November 2023 milestone Nov 27, 2023
@benibenj benibenj removed their assignment Nov 28, 2023
@aiday-mar aiday-mar removed their assignment Nov 28, 2023
@justschen justschen removed their assignment Nov 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants