Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multi-line prompts in sticky scroll #197735

Closed
Tyriar opened this issue Nov 8, 2023 · 0 comments · Fixed by #197835
Closed

Support multi-line prompts in sticky scroll #197735

Tyriar opened this issue Nov 8, 2023 · 0 comments · Fixed by #197835
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal-sticky-scroll
Milestone
November 2023

Comments

@Tyriar
Copy link
Member

Tyriar commented Nov 8, 2023

Sticky scroll added initially in #197558

When using a multi-line prompt such as starship:

image

Sticky scroll should show both lines of the prompt (technically the empty line above is a prompt line too but it's empty). Currently only a single line is shown:

image
@Tyriar Tyriar added feature-request Request for new features or functionality terminal-sticky-scroll labels Nov 8, 2023
@Tyriar Tyriar added this to the November 2023 milestone Nov 8, 2023
@Tyriar Tyriar self-assigned this Nov 8, 2023
Tyriar added a commit that referenced this issue Nov 9, 2023
@Tyriar
Implement terminal multi-line prompt stick scroll
c03ee9b 
Fixes #197735
This was referenced Nov 9, 2023
Merged
Closed
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 9, 2023
@Tyriar Tyriar mentioned this issue Nov 27, 2023
Closed
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal-sticky-scroll
Projects
None yet
Milestone
November 2023
Development

Successfully merging a pull request may close this issue.

Implement terminal multi-line prompt stick scroll microsoft/vscode
2 participants
@Tyriar @vscodenpa