Hard to launch a workbench without a workspace

[yiliang114]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.77.0 1b6f8eb
• OS Version: Mac os intel

Steps to Reproduce:

1. git clone the vscode latest source code.
2. Use cmd + shift + b keybinding to start the development process. (Core - Build and Ext - Build).

My purpose is to start a blank workspace, similar to screenshot. But the current startup method, I can't achieve this effect.

If I execute ./scripts/code-web.sh directly, the vscode-web-playground extension will be automatically downloaded and loaded. The presence of a memory fileSystem is not what I expected.

vscode/scripts/code-web.js

Line 62 in 1b6f8eb

if (args['playground'] === true || (args['_'].length === 0 && !args['folder-uri'])) {

If I execute ./scripts/code-web.sh --folder-uri=memfs:/test which folder-uri is random, Explorer will display the failed path, which is not the effect I want.

If I execute ./scripts/code-web.sh . , Explorer will display files from local

My advice is only use ./scripts/code-web.sh --playground to load vscode-web-playground extension, and if use./scripts/code-web.sh without any arguments, no fileSystemProvider extension by default

[vscodenpa]

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.76.1. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

[yiliang114]

Hi @aeschli I did not find the use of --no-playground. What is the reason for adding this filter condition? It seems a little redundant

vscode/scripts/code-web.js

Line 76 in d7014b6

serverArgs.push(...process.argv.slice(2).filter(v => !v.startsWith('--playground') && v !== '--no-playground'));

If it is no longer useful, I can remove it.

[aeschli]

We use the minimist library for argument parsing. For boolean arguments it allows to write --playground to enable and --no-playground to disable.

[yiliang114]

We use the minimist library for argument parsing. For boolean arguments it allows to write --playground to enable and --no-playground to disable.

Thanks a lot, i got it. So the --playground parameters still need to be filtered out, I have resubmitted the code.

[aeschli]

You can turn get an empty workspace by running ./scripts/code-web.sh -- --playground=false

Isn't that good enough?

[yiliang114]

You can turn get an empty workspace by running ./scripts/code-web.sh -- --playground=false

Isn't that good enough?

@aeschli Thank you for your time. Please allow me to hold on a little longer.

My original intention was use./scripts/code-web.sh --playground to add vscode-web-playground extension defaultly and use ./scripts/code-web.sh would get an empty workspace.

The difference with the current logic is that now use ./scripts/code-web.sh to add vscode-web-playground extension defaultly and use ./scripts/code-web.sh -- --playground=false would get an empty workspace.

Maybe ./scripts/code-web.sh --playground is more like letting developers know they're going to load vscode-web-playground extension. But this is only my superficial understanding, if you think it is inappropriate or unnecessary, I will close the issue and PR

[aeschli]

I guess both setups are useful.

• The playground with its memory file system is there to have some resources available right away to allow the developer to test some features code-serverless
• The empty workspace would be more consistent with other start scripts that do not add anything on top of starting code. Also it allows to open local folders

I'm fine changing the default. I don't think any of our tests depend on it.

@bpasero What do you think?

To teach devs about the playground/empty workspace, we could just print some more help text when code-web is started.

[bpasero]

To clarify, what is the suggestion? To not show the in-memory sample thingy for scripts/code-web.sh:

?

[yiliang114]

To clarify, what is the suggestion? To not show the in-memory sample thingy for scripts/code-web.sh:

?

yes

[bpasero]

Not sure, scripts/code-web.sh is mainly meant for development. And you cannot really open a folder in that experience, so opening an empty instance makes it harder for someone to open files?

[aeschli]

@bpasero You can, there's the Open Folder button that will open a local folder dialog like in vscode.dev.
Also you can start scripts/code-web.sh with a path to a local folder, to open a virtual filesystem serving the contents found on disk (see https://github.com/microsoft/vscode-test-web)

[bpasero]

Then, go for it 👍

[yiliang114]

Hey, @aeschli Is there anything else to confirm?

What else do I need to change? Or Keep the current design?