fix: close #176763, modify the conditions to load vscode-web-playground #176771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We want to update the argument description: Line 45 in efe3773 |
yiliang114
force-pushed
the
cold-chimpanzee
branch
from
a390ef5
to
d0a24ff
Compare
|
@aeschli I try to update the argument description, please take time to take a look |
aeschli
requested changes
Mar 23, 2023
yiliang114
force-pushed
the
cold-chimpanzee
branch
from
d0a24ff
to
4c79346
Compare
|
Looks good, thanks. Will merge next week! |
Thank you for your help! 😊 |
yiliang114
force-pushed
the
cold-chimpanzee
branch
from
4c79346
to
0df1718
Compare
aeschli
approved these changes
Apr 4, 2023
sandy081
approved these changes
Apr 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #176763, modify the conditions to load vscode-web-playground, and allow developers to start workbench without workspace