Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ITerminalContribution.layout #176826

Closed
meganrogge opened this issue Mar 10, 2023 · 0 comments · Fixed by #176979
Closed

add ITerminalContribution.layout #176826

meganrogge opened this issue Mar 10, 2023 · 0 comments · Fixed by #176979
Assignees
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders terminal-accessibility Issues related to the terminal help widget, accessibility buffer, or navigation mode
Milestone

Comments

@meganrogge
Copy link
Contributor

          It's a bit ugly to expose this, how about instead we add `ITerminalContribution.layout` and call it for all contributions within `TerminalInstance`? That seems like it would be useful for future contributions.

For this case we would only need to listen to the first layout:

layout() {
  if (!this._doneLayout) {
    this._accessibleBufferWidget = this._instantiationService.createInstance(AccessibleBufferWidget, this._instance.instanceId, xterm);
    this._doneLayout = true;
  }
}

Originally posted by @Tyriar in #176413 (comment)

@meganrogge meganrogge added this to the March 2023 milestone Mar 11, 2023
@meganrogge meganrogge added debt Code quality issues terminal-accessibility Issues related to the terminal help widget, accessibility buffer, or navigation mode labels Mar 13, 2023
meganrogge added a commit that referenced this issue Mar 13, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders terminal-accessibility Issues related to the terminal help widget, accessibility buffer, or navigation mode
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants