Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Toggle Command of Webview can only open, but not close panel #182266

Open
yiliang114 opened this issue May 12, 2023 · 1 comment · May be fixed by #182279
Open

The Toggle Command of Webview can only open, but not close panel #182266

yiliang114 opened this issue May 12, 2023 · 1 comment · May be fixed by #182279
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug webview Webview issues
Milestone

Comments

@yiliang114
Copy link
Contributor

yiliang114 commented May 12, 2023

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: latest vscode.dev or Version: 1.78.0 (Universal)

Version: 1.78.0 (Universal)
Commit: 252e546
Date: 2023-05-03T20:11:00.813Z
Electron: 22.4.8
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Darwin x64 21.3.0
Sandboxed: Yes

  • OS Version: 12.2.1 (21D62)

Steps to Reproduce:

  1. Open Command Panel input Toggle, Select any toggle command like workbench.actions.view.problems and call it twice.
  2. If there is no accident, the execution of the two commands can open the panel and then close it.
  3. Then open Command Panel input Toggle again, select some webview view container command like workbench.action.terminal.toggleTerminal, when the panel is opened, no matter how many times the command is executed, the panel will not close again.

image

bug6

@yiliang114
Copy link
Contributor Author

yiliang114 commented May 12, 2023

I found the reason, but I don't know how to repair it yet.

image

When we use the command to call out webview type of panel, document.activeElement the value cannot become webview, but will always be on the last activated element, so isAncestorUsingFlowTo will always return false

image

@yiliang114 yiliang114 changed the title The Toggle Command of Webview can only open, not close panel The Toggle Command of Webview can only open, but not close panel May 12, 2023
yiliang114 added a commit to yiliang114/vscode that referenced this issue May 12, 2023
@mjbvz mjbvz added this to the June 2023 milestone May 25, 2023
yiliang114 added a commit to yiliang114/vscode that referenced this issue May 31, 2023
@mjbvz mjbvz modified the milestones: June 2023, July 2023 Jun 8, 2023
@mjbvz mjbvz modified the milestones: July 2023, August 2023 Jul 18, 2023
@mjbvz mjbvz modified the milestones: August 2023, September 2023 Aug 29, 2023
@mjbvz mjbvz modified the milestones: September 2023, October 2023 Sep 26, 2023
@mjbvz mjbvz modified the milestones: October 2023, November 2023 Oct 25, 2023
@mjbvz mjbvz modified the milestones: November 2023, December 2023 Nov 21, 2023
yiliang114 added a commit to yiliang114/vscode that referenced this issue Nov 28, 2023
yiliang114 added a commit to yiliang114/vscode that referenced this issue Nov 28, 2023
yiliang114 added a commit to yiliang114/vscode that referenced this issue Nov 28, 2023
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug webview Webview issues labels Dec 12, 2023
@mjbvz mjbvz modified the milestones: December / January 2024, February 2024 Jan 22, 2024
@mjbvz mjbvz modified the milestones: February 2024, On Deck Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug webview Webview issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants