fix: to #182266, Corrected Webview hasFocus check #182279
Conversation
| if (viewContainerId && viewContainerId === activePanel?.getId()) { | ||
| return true; | ||
| } | ||
|
|
||
| const container = this.getContainer(part); | ||
|
|
||
| return !!container && isAncestorUsingFlowTo(activeElement, container); |
There was a problem hiding this comment.
Have you investigated why isAncestorUsingFlowTo doesn't work in this case? Ideally this part of the code shouldn't have to know anything webview specific
There was a problem hiding this comment.
Have you investigated why
isAncestorUsingFlowTodoesn't work in this case? Ideally this part of the code shouldn't have to know anything webview specific
Yes, I commented on #182266 (comment) earlier.
it looks like the activeElement is incorrect when Webview clicked
There was a problem hiding this comment.
Have you investigated why
isAncestorUsingFlowTodoesn't work in this case? Ideally this part of the code shouldn't have to know anything webview specific
Have you investigated why
isAncestorUsingFlowTodoesn't work in this case? Ideally this part of the code shouldn't have to know anything webview specific
I think what you said is right. Ideally, there should be no special treatment for it. I'll try to see if activeElement value can be corrected.
There was a problem hiding this comment.
Have you investigated why
isAncestorUsingFlowTodoesn't work in this case? Ideally this part of the code shouldn't have to know anything webview specific
hi @mjbvz activeElement looks like a read-only property, we don't seem to be able to actively modify the value for it.
yiliang114
force-pushed
the
fix/webview-view-container-toggle
branch
from
ec38a3d
to
c30cebe
Compare
Close #182266.