Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference Review, Improve Voice Over #186420

Closed
roblourens opened this issue Jun 27, 2023 · 4 comments · Fixed by #188165
Closed

Difference Review, Improve Voice Over #186420

roblourens opened this issue Jun 27, 2023 · 4 comments · Fixed by #188165
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues diff-editor Diff editor issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@roblourens
Copy link
Member

Testing #186213

Maybe this is related to #186402, but as I tried it I got different results from that mode but it never seemed to read what I expected

I enable screenreader mode and voiceover, and every time I press F7, this is what it reads. I don't really know what the first part is telling me, and also it says "7 lines changed" but this was a file with 2 change chunks, each with just one changed line, so no idea where it is getting 7.

image
@roblourens
Copy link
Member Author

I guess it's telling me that I can use those commands on the current chunk, but it should read the current chunk, possibly first. Also I don't know what "9 items" refers to

@meganrogge meganrogge removed their assignment Jun 27, 2023
@hediet hediet added feature-request Request for new features or functionality accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues diff-editor Diff editor issues labels Jun 28, 2023
@hediet hediet added this to the July 2023 milestone Jun 28, 2023
@hediet
Copy link
Member

hediet commented Jun 28, 2023

I fixed #186402 and compared the new editor with the old editor. It seems they generate the same voiceover.
I think the voice over is not great and needs improvement, but at least it is not a regression.

@meganrogge meganrogge removed their assignment Jul 10, 2023
@hediet hediet changed the title VoiceOver doesn't read text of diff Difference Review, Improve Voice Over Jul 11, 2023
@hediet
Copy link
Member

hediet commented Jul 11, 2023

This is what I get (pressed F7 and then arrow down):

Difference review. Use "Stage | Unstage | Revert Selected Ranges" commands  list
Difference 1 of 1: original line 638, 7 lines changed, modified line 638, 7 lines changed  1 of 9  level 1
 header.appendChild(cell); unchanged line 638  2 of 9  level 1

@hediet
Copy link
Member

hediet commented Jul 18, 2023

Now it says this:

Accessible Diff Viewer. Use arrow up and down to navigate.  list
Difference 3 of 5: original line 101, 18 lines changed, modified line 101, 17 lines changed  1 of 30  level 1

hediet added a commit that referenced this issue Jul 18, 2023
…188165)

* Rewrites accessible diff viewer (formerly called difference review)
Fixes #186420, Adresses #184229

* Fixes CI.

* Fixes bug
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jul 18, 2023
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 19, 2023
@hediet hediet added the verification-needed Verification of issue is requested label Jul 21, 2023
@roblourens roblourens added the verified Verification succeeded label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues diff-editor Diff editor issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants