Test continue on for PR comments

[alexr00]

Refs: #183449

• macOS @joaomoreno
• linux @ulugbekna
• windows @bpasero

Complexity: 3

Create Issue

---

When you checkout a PR with GitHub Pull Requests and Issues and write a comment without submitting the comment, we now save these unsubmitted comments for "continue on".

Setup:
You will need two machines that you can install desktop VS Code insiders on. vscode.dev can't be used to test this.
NOTE: Make sure you have the same version of VS Code and GitHub Pull Requests and Issues on both machines
Install the GitHub Pull Requests and Issues extension on both machines.
Install the GitHub Repositories extension on both machines.
Turn on "Cloud changes" from the Account menu on both machines.

To verify:

1. Check out a PR on machine one using the GitHub Repositories + Remote Repositories extension.
   a. Run the command: "Remote Repositories: Open Remote Repository..."
   b. Choose the option to "Open a Pull Request from GitHub"
   c. Find your PR in the list and choose it
2. On machine two, check out the same PR with the GitHub Repositories extension.
3. Back to machine one: Start to write a comment. Do not submit the comment.
4. On machine one, make a small edit in a file. (@joyceerhl, this seems to be needed for the "Store working changes in cloud" command)
5. On machine one, Command: "Cloud Changes: Store Working Changes in Cloud"
6. On machine two, open the file that you were leaving a comment in on machine one in step two.
7. On machine two, "Cloud Changes: Resume Latest Changes from Cloud"
8. Verify that the comment from machine one now shows on machine two

Once you have this working some other good things to test (Each time you test you will need to close the old comment, make a new comment, and make a new small edit):

• Does the sync still work if the file is closed at the time that you "Resume"?
• Does "Resuming" an unsubmitted reply to a submitted comment work?
• Does "Resuming" multiple unsubmitted comments work?

[bpasero]

@alexr00 that did not work for me at least on macOS. I had tried with https://insiders.vscode.dev/github/microsoft/vscode/pull/191241 having previously added a comment from desktop. Is there a way to figure out?

Web:

Desktop:

[ulugbekna]

Didn't work for me either.
I checked out a PR on insiders.vscode.dev, started typing in a comment, but didn't submit.
Opened insiders desktop, checked out same PR - no comments

[alexr00]

Looks like I have some missing steps. In the setup:

Turn on "Cloud changes" from the Account menu

And steps 3, 4, and 7.

[alexr00]

There's still an issue with this feature. This TPI is currently blocked.

[chrmarti]

Trying on mac without luck:

Desktop:

insiders.vscode.dev:

Both are on today's Insiders build and the latest PR extension pre-release from yesterday.

[chrmarti]

From the Cloud Changes output channel on insiders.vscode.dev:

2023-09-27 11:14:56.831 [info] Checking for pending cloud changes...
2023-09-27 11:14:57.122 [info] Matching identity {"remote":"https://github.com/microsoft/vscode-remote-containers","ref":"chrmarti/scared-whitefish","sha":"fa1b08898336475e8734a272c9ab1580c56d0c6f"} against edit session folder identity {"remote":"https://github.com/microsoft/vscode-remote-containers.git","ref":"chrmarti/scared-whitefish","sha":"fa1b08898336475e8734a272c9ab1580c56d0c6f"}...
2023-09-27 11:14:57.124 [info] Skipping applying 2 changes from edit session with ref aecbd60d-9a64-4a8d-bbd2-669b67b02833 as no matching workspace folder was found.

Desktop:

2023-09-27 11:09:26.658 [info] Storing edit session...
2023-09-27 11:09:26.829 [info] Stored edit session with ref aecbd60d-9a64-4a8d-bbd2-669b67b02833.

[ulugbekna]

Works when testing with insiders open in two tabs

[alexr00]

@bpasero and @anthonykim1 could you please test by opening a PR in insiders.vscode.dev in two different browser tabs using the same steps to open the PR in each tab instead of 1 insiders.vscode.dev instance and one VS Code desktop instance? There appears to be a URI mismatch sometimes, which I'm tracking in #194288. Using the same insiders.vscode.dev URL open in two browser tabs appears to avoid this.

[bpasero]

It also does not work for me between 2 browser tabs (the change restores, but not the comment). I suggest to move this feature and testing into October.

[alexr00]

Moving to October so we can figure out the URI mismatch.

[anthonykim1]

Let me know @alexr00 if you still wanted me to test this

[alexr00]

For now, no further testing is needed. We'll test again during the October endgame.

[ulugbekna]

It still doesn't work for me, sorry :-(

[anthonykim1]

I tried multiple times trying to get this work, but still having some trouble. Tried to use more of the "store in cloud" and the "show cloud changes" but can't seem to see the comments even after actually submitting the comments from different device.

[alexr00]

Just walked through with @ulugbekna, and my instructions for checking out the PR were not good enough. I've updated the test steps. Here's how to check out the PR:
a. Run the command: "Remote Repositories: Open Remote Repository..."
b. Choose the option to "Open a Pull Request from GitHub"
c. Find your PR in the list and choose it

It also works better if you open the PR on both machines before trying the feature. I've re-ordered the steps to include this.

[joaomoreno]

Following the steps very closely actually works. But the entire flow feels flimsy.

• I kinda expected this to just work in regular checked out repos, not only using Remote Repositories.
• I also kinda expected it to just work without the Store and Resume commands
• Do we already have an issue for this seems to be needed for the "Store working changes in cloud" command?
• Is there any way to test this as it's intended for users to use it, not via all these steps?

[bpasero]

This worked only once for me and the things I have to remember to test this are incredibly complex: why do I have to make an edit, why do I have to run a command to sync, why does this not happen automatically? Think about settings sync: it just works.

@alexr00 @joyceerhl I would suggest you two sit together, test the flow end to end, improve the user experience and then we test this again.

[alexr00]

Thank you everyone for your persistence in testing this!