Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NLS: decouple from loader (helps for ESM) #212542

Closed
bpasero opened this issue May 12, 2024 · 0 comments · Fixed by #214588
Closed

NLS: decouple from loader (helps for ESM) #212542

bpasero opened this issue May 12, 2024 · 0 comments · Fixed by #214588
Assignees
@bpasero
Labels
insiders-released Patch has been released in VS Code Insiders on-testplan plan-item VS Code - planned item for upcoming
Milestone
July 2024

Comments

@bpasero
Copy link
Member

bpasero commented May 12, 2024

Remove our dependency to the nls! loader plugin.

Maybe helps for #153256
@bpasero bpasero added the plan-item VS Code - planned item for upcoming label May 12, 2024
@bpasero bpasero added this to the May 2024 milestone May 12, 2024
@bpasero bpasero self-assigned this May 12, 2024
@kieferrm kieferrm mentioned this issue May 13, 2024
Closed
52 tasks
@jrieken jrieken mentioned this issue May 15, 2024
Closed
@bpasero bpasero modified the milestones: May 2024, June 2024 May 28, 2024
@kieferrm kieferrm mentioned this issue Jun 12, 2024
Closed
50 tasks
@bpasero bpasero mentioned this issue Jun 22, 2024
Closed
4 tasks
@bpasero bpasero modified the milestones: June 2024, July 2024 Jun 24, 2024
@bpasero bpasero mentioned this issue Jun 25, 2024
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 28, 2024
@mihailik mihailik mentioned this issue Jul 7, 2024
Closed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
insiders-released Patch has been released in VS Code Insiders on-testplan plan-item VS Code - planned item for upcoming
Projects
None yet
Milestone
July 2024
Development

Successfully merging a pull request may close this issue.

Implement NLS without AMD loader microsoft/vscode
3 participants
@bpasero @vscodenpa and others