-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web extension broadcomMFD.hlasm-language-support
no longer works
#220171
Comments
There was a recent change to our NLS story that requires @aeschli I wonder how we can communicate this to extension authors that they will have to update, besides putting release notes. |
As mentioned above, tried with these versions, including the latest: v0.22 |
And I'd love to help you guys with fixing, give me some clues what's changed with NLS. I can see these, but they're quite terse on details. NLS: decouple from loader (helps for ESM) #212542 Implement NLS without AMD loader #214588 nls follow up debt work #219265 I'll try to check out https://github.com/microsoft/vscode-test-web update references and see if it comes with any issues by itself. But hints and tips appreciated! |
I can reproduce with a fresh extension, but I am not clear how my NLS changes impact this, given we pushed a fix for that 🤔 |
PR to vscode-test-web repo to unblock the functionality by falling back onto Clamp VSCode download to stable release until NLS issue on Insiders is fixed #129 At least my own development is unblocked, but I suspect others might appreciate it. |
I think we would rather address the real issue. |
Sure, I just thought one does not preclude another. |
The web worker is now using `importScript` directive in a data URL which is no longer the same `script-src` as the iframe when running built where we use `webEndpointUrlTemplate`. This breaks `vscode-test-web` that runs from `localhost` so we allow `http://localhost`
This bug has been fixed in the latest release of VS Code Insiders! @mihailik, you can help us out by commenting If things still don't seem right, please ensure you're on version b23e791 of Insiders (today's or later - you can use Happy Coding! |
I am still getting errors:
EDIT: |
I think this is somehow related to my problem
|
I would need a step by step instruction how to reproduce with your extension, please be detailed and assume I haver never used that extension or ran it. |
…rosoft#221030) The web worker is now using `importScript` directive in a data URL which is no longer the same `script-src` as the iframe when running built where we use `webEndpointUrlTemplate`. This breaks `vscode-test-web` that runs from `localhost` so we allow `http://localhost`
I steps to reproduce the problem:
I managed to find a workaround and in the process I discovered a few additional details. |
I can reproduce, though I do not fully understand why the vscode/src/vs/workbench/services/extensions/worker/webWorkerExtensionHostIframe.html Lines 96 to 104 in 316c67d
The vscode/src/vs/workbench/services/extensions/worker/webWorkerExtensionHostIframe.html Lines 4 to 8 in 316c67d
I can confirm that the adding @mihailik where do you see that you also need |
broadcomMFD.hlasm-language-support
no longer works
I assume that the |
/verified |
Thanks, I did not figure out that 2 different users are in this issue, so while the original issue seems resolved, there is still the issue with |
@bpasero I think this can be closed now. |
@slavek-kucera did the change in #223153 help? |
@bpasero Not sure, I've found a way to build the extension so that I don't encounter the problem anymore. |
Does this issue occur when all extensions are disabled?: Yes/No
VS Code Version:
Version: 1.91.0 (user setup)
Commit: ea1445c
Date: 2024-07-01T18:52:22.949Z
Electron: 29.4.0
ElectronBuildId: 9728852
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Windows_NT x64 10.0.19045
VS Code Version loaded for debugging:
Version: 1.92.0-insider
Commit: 82104a3
Date: 2024-07-05T00:00:00.000Z
Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/127.0.0.0 Safari/537.36
Steps to Reproduce:
yo code
as described in the official documentation at Web Extensions | Visual Studio Code Extension APInpm install
if necessary.npm run run-in-browser
to debug Web ExtensionThis does 𝗻𝗼𝘁 look like vscode-test-web issue
The session fails on new, and on old well-used versions of @vscode/test-web
Also tried on MacOS (M1), on Ubuntu (arm64 VM) and Windows 10.
Never works.
The text was updated successfully, but these errors were encountered: