Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In insiders vscode.dev our extension cannot load files into the workspace anymore #223134

Closed
IanMatthewHuff opened this issue Jul 22, 2024 · 6 comments · Fixed by #223153
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded web Issues related to running VSCode in the web
Milestone

Comments

@IanMatthewHuff
Copy link
Member

Does this issue occur when all extensions are disabled?: No

  • VS Code Version: Current insiders.vscode.dev
  • OS Version: Web issue only (repro)

The repro steps for this are entering via the VS Code for education route for insiders.vscode.dev

Steps to Reproduce:

  1. Login to ppe.vscodeedu.com with MS credentials
  2. From the courses list, select the 'Getting Started' course
  3. insiders.vscode.dev should be launched with our extension and course loaded
  4. At this point you can already see the errors in the dev console
  5. But to see the specific issue select the "Coding Challenge" section
    image
    In this section a code editor file should have been opened up in the editor, but it is missing.

We see the following in the dev console when the course is loaded. I don't have a full bead on exactly what is happening here, but we have not been changing the extension this sprint, so it seems to be a recent new issue that is just in insiders and not in stable (which works fine still and does not have the errors).

image

I took a look at recent issues and this one comment appeared here that might be related? #220171 (comment)

@IanMatthewHuff
Copy link
Member Author

insiders.vscode.dev-1721684119886.log

Adding the log file here.

@IanMatthewHuff
Copy link
Member Author

For comparison, this is the same scenario in stable vscode.dev:
image

And insiders:
image
Note the errors, plus terminal and editor have not opened up.

@IanMatthewHuff
Copy link
Member Author

@bpasero Hope you don't mind a direct ping here, but I think you might have context both on the VS Code for Education route and possibly on the issue above?

@mjbvz
Copy link
Collaborator

mjbvz commented Jul 22, 2024

@deepak1556 believes this is related to #214588

Looks like we may need to add blob: to the web-worker-ext-host-iframe iframe content security policy. Taking a look at this now

cc @bpasero @alexdima @joaomoreno

@mjbvz mjbvz self-assigned this Jul 22, 2024
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug web Issues related to running VSCode in the web labels Jul 22, 2024
mjbvz added a commit to mjbvz/vscode that referenced this issue Jul 22, 2024
mjbvz added a commit that referenced this issue Jul 22, 2024
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jul 22, 2024
@vscodenpa vscodenpa added this to the July 2024 milestone Jul 22, 2024
@deepak1556 deepak1556 added the verified Verification succeeded label Jul 23, 2024
@deepak1556
Copy link
Collaborator

I was able to verify the issue has been addressed in latest insiders following the steps from OP. @IanMatthewHuff please also confirm on your end. Thanks!

@IanMatthewHuff
Copy link
Member Author

Looks good now. Thanks for the quick fix!

@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 24, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded web Issues related to running VSCode in the web
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants