Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non registered settings are read from default profile when a custom profile is active #229955

Closed
sandy081 opened this issue Sep 27, 2024 · 3 comments · Fixed by #229959 or #233855
Closed

Non registered settings are read from default profile when a custom profile is active #229955

sandy081 opened this issue Sep 27, 2024 · 3 comments · Fixed by #229959 or #233855
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug config VS Code configuration, set up issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
November 2024

Comments

@sandy081
Copy link
Member

Steps to Reproduce:

  1. Set "workbench.panel.showLabel": false setting in default profile
  2. Open a new window, create a custom profile and make that profile active

🐛 Panel shows with icons. Above setting is read from default profile even though it is not an application scope setting
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug config VS Code configuration, set up issues labels Sep 27, 2024
@sandy081 sandy081 added this to the October 2024 milestone Sep 27, 2024
@sandy081 sandy081 self-assigned this Sep 27, 2024
sandy081 added a commit that referenced this issue Sep 27, 2024
@sandy081
fix #229955
114554b
@sandy081 sandy081 mentioned this issue Sep 27, 2024
Merged
sandy081 added a commit that referenced this issue Sep 27, 2024
@sandy081
fix #229955 (#229959)
6043ad1
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 27, 2024
@rzhao271 rzhao271 added the verified Verification succeeded label Oct 24, 2024
@sandy081
Copy link
Member Author

This fix broke the remote SSH scenario - #232602 - Hence reverting this. Fixing this require #224236 to be fixed.

@sandy081 sandy081 reopened this Nov 11, 2024
@sandy081 sandy081 removed verified Verification succeeded insiders-released Patch has been released in VS Code Insiders labels Nov 11, 2024
@sandy081 sandy081 modified the milestones: October 2024, November 2024 Nov 11, 2024
sandy081 added a commit that referenced this issue Nov 11, 2024
@sandy081
Revert "fix #229955 (#229959)"
4d7ad6d 
This reverts commit 6043ad1.
sandy081 added a commit that referenced this issue Nov 11, 2024
@sandy081
Revert "fix #229955 (#229959)"
121787c 
This reverts commit 6043ad1.
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Nov 11, 2024
sandy081 added a commit that referenced this issue Nov 11, 2024
@sandy081
Revert "fix #229955 (#229959)" (#233568)
d887bdb 
This reverts commit 6043ad1.
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 12, 2024
sandy081 added a commit that referenced this issue Nov 12, 2024
@sandy081
Reapply "fix #229955 (#229959)" (#233567)
3e435d6 
This reverts commit 86a992a.
sandy081 added a commit that referenced this issue Nov 12, 2024
@sandy081
Revert "Reapply "fix #229955 (#229959)" (#233567)"
714990e 
This reverts commit 3e435d6.
sandy081 added a commit that referenced this issue Nov 14, 2024
@sandy081
Handle resolver extension points before activating (#233721)
6dd6e70 
* Reapply "fix #229955 (#229959)" (#233567)

This reverts commit 86a992a.

* Handle resolver extension points before activating - fixes #224236

* Revert "Reapply "fix #229955 (#229959)" (#233567)"

This reverts commit 3e435d6.

* improve handling resolver extensions

* move check into for loop

* clean up

* revert to fix failing test

* use existing method

* review feedback - stream resolved extensions

* fix

* undo
sandy081 added a commit that referenced this issue Nov 14, 2024
@sandy081
Reapply "fix #229955 (#229959)" (#233567)
abc5b0e 
This reverts commit 86a992a.
@sandy081 sandy081 mentioned this issue Nov 14, 2024
Merged
sandy081 added a commit that referenced this issue Nov 14, 2024
@sandy081
fix #229955 (#233855)
fd5fa8e 
Reapply "fix #229955 (#229959)" (#233567)

This reverts commit 86a992a.
NikolaRHristov added a commit to CodeEditorLand/Editor that referenced this issue Nov 19, 2024
@NikolaRHristov
Revert "fix microsoft#229955 (microsoft#229959)" (microsoft#233567)
ccaacd5 
This reverts commit 6043ad1.
NikolaRHristov pushed a commit to CodeEditorLand/Editor that referenced this issue Nov 19, 2024
@sandy081 @NikolaRHristov
fix microsoft#229955 (microsoft#233855)
dab4252 
Reapply "fix microsoft#229955 (microsoft#229959)" (microsoft#233567)

This reverts commit 86a992a.
@alexr00
Copy link
Member

alexr00 commented Dec 5, 2024

Looks like "workbench.panel.showLabels" is a registered setting now.

@alexr00 alexr00 added the verified Verification succeeded label Dec 5, 2024
@alexr00
Copy link
Member

alexr00 commented Dec 5, 2024

Verified with "githubPullRequests.experimental.notificationsScore": true.

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug config VS Code configuration, set up issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
November 2024
Development

Successfully merging a pull request may close this issue.

fix #229955 microsoft/vscode
fix #229955 microsoft/vscode
3 participants
@rzhao271 @sandy081 @alexr00