Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle resolver extension points before activating #233721

Merged
merged 12 commits into from
Nov 14, 2024
Merged

Conversation

sandy081
Copy link
Member

@sandy081 sandy081 commented Nov 12, 2024

fixes #224236

  • Handle resolver extension extension points before activating it
  • Only those extension points which can handle resolver extension point are handled at this stage
  • Once all extensions are resolved, all extensions extension points are handled. Note that previously handled extension points of resolver extensions will not be handled due to the nature of how extension points are handled that they won't allow duplication.

@sandy081 sandy081 requested a review from alexdima November 12, 2024 18:52
@sandy081 sandy081 self-assigned this Nov 12, 2024
@sandy081 sandy081 enabled auto-merge (squash) November 12, 2024 18:52
@vs-code-engineering vs-code-engineering bot added this to the November 2024 milestone Nov 12, 2024
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sandy081 sandy081 merged commit 6dd6e70 into main Nov 14, 2024
8 checks passed
@sandy081 sandy081 deleted the sandy081/grubby-kite branch November 14, 2024 17:33
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Dec 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support configuration contribution points of resolver extensions
2 participants