Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor GPU: Folding sections doesn't re-render lines below correctly #234214

Closed
Tyriar opened this issue Nov 19, 2024 · 0 comments · Fixed by #234613
Closed

Editor GPU: Folding sections doesn't re-render lines below correctly #234214

Tyriar opened this issue Nov 19, 2024 · 0 comments · Fixed by #234613
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug editor-gpu Editor GPU rendering related issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
November 2024

Comments

@Tyriar
Copy link
Member

Tyriar commented Nov 19, 2024 •
edited
Loading

Not that this is the end of the file:

Image
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug editor-gpu Editor GPU rendering related issues labels Nov 19, 2024
@Tyriar Tyriar added this to the November 2024 milestone Nov 19, 2024
@Tyriar Tyriar self-assigned this Nov 19, 2024
@Tyriar Tyriar moved this from Todo to In Review in VS Code Editor GPU Renderer Nov 25, 2024
@Tyriar Tyriar mentioned this issue Nov 25, 2024
Merged
Tyriar added a commit that referenced this issue Nov 25, 2024
@Tyriar
Handle line mapping changed and don't update buffers after decoration…
fd39738 
… change

Line mapping is the cause of the problems with folding, for decorations
we only want to invalidate the up to date lines cache since it won't
affect other lines afaict.

Fixes #234614
Part of #234214
@Tyriar Tyriar mentioned this issue Nov 25, 2024
Merged
@Tyriar Tyriar closed this as completed in 2833b09 Nov 25, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in VS Code Editor GPU Renderer Nov 25, 2024
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Nov 25, 2024
osortega pushed a commit that referenced this issue Nov 26, 2024
@Tyriar @osortega
Don't clobber other view events with final one
4e5bced 
Fixes #234474
Fixes #234214
osortega pushed a commit that referenced this issue Nov 26, 2024
@Tyriar @osortega
Handle line mapping changed and don't update buffers after decoration…
45d8cdb 
… change

Line mapping is the cause of the problems with folding, for decorations
we only want to invalidate the up to date lines cache since it won't
affect other lines afaict.

Fixes #234614
Part of #234214
Rheasilvia pushed a commit to Rheasilvia/vscode that referenced this issue Nov 26, 2024
@Tyriar
Don't clobber other view events with final one
11c4f40 
Fixes microsoft#234474
Fixes microsoft#234214
Rheasilvia pushed a commit to Rheasilvia/vscode that referenced this issue Nov 26, 2024
@Tyriar
Handle line mapping changed and don't update buffers after decoration…
b0b2d5f 
… change

Line mapping is the cause of the problems with folding, for decorations
we only want to invalidate the up to date lines cache since it won't
affect other lines afaict.

Fixes microsoft#234614
Part of microsoft#234214
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 26, 2024
@Tyriar Tyriar added the verified Verification succeeded label Dec 5, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug editor-gpu Editor GPU rendering related issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
VS Code Editor GPU Renderer
Status: Done
Milestone
November 2024
Development

Successfully merging a pull request may close this issue.

Don't clobber other view events with final one microsoft/vscode
1 participant
@Tyriar