Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle line mapping changed and don't update buffers after decoration change #234618

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Nov 25, 2024

Line mapping is the cause of the problems with folding, for decorations
we only want to invalidate the up to date lines cache since it won't
affect other lines afaict.

Fixes #234614
Part of #234214

Merge after #234613

… change

Line mapping is the cause of the problems with folding, for decorations
we only want to invalidate the up to date lines cache since it won't
affect other lines afaict.

Fixes #234614
Part of #234214
@Tyriar Tyriar added this to the November 2024 milestone Nov 25, 2024
@Tyriar Tyriar self-assigned this Nov 25, 2024
@Tyriar Tyriar marked this pull request as ready for review November 25, 2024 23:04
@Tyriar Tyriar enabled auto-merge November 25, 2024 23:04
@Tyriar Tyriar merged commit 9324d6c into main Nov 25, 2024
8 checks passed
@Tyriar Tyriar deleted the tyriar/234474__234614 branch November 25, 2024 23:57
osortega pushed a commit that referenced this pull request Nov 26, 2024
Handle line mapping changed and don't update buffers after decoration change
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Editor GPU: Only re-render lines where decorations change on ViewDecorationsChangedEvent
2 participants