Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminals created before panel is initialized have the wrong width #28138

Closed
Tyriar opened this issue Jun 6, 2017 · 3 comments
Closed

Terminals created before panel is initialized have the wrong width #28138

Tyriar opened this issue Jun 6, 2017 · 3 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release terminal Integrated terminal issues verified Verification succeeded
Milestone
May Recovery 2017

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 6, 2017

This is happening because the pty is initialized with a width of 80 initially because we don't know about the dimensions of the screen. Maybe a resize should be run async after the panel is displayed?

image
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels Jun 6, 2017
@Tyriar Tyriar added this to the June 2017 milestone Jun 6, 2017
@Tyriar Tyriar self-assigned this Jun 6, 2017
@Tyriar Tyriar mentioned this issue Jun 6, 2017
Closed
@Tyriar
Copy link
Member Author

Tyriar commented Jun 12, 2017

I just observed this with the height as well, running git log was putting the actual top of the log above the viewport. I counted 24 rows which is the default.

@Tyriar Tyriar closed this as completed in 1cc8f3c Jun 12, 2017
@Tyriar Tyriar modified the milestones: May Recovery 2017, June 2017 Jun 12, 2017
@Tyriar Tyriar mentioned this issue Jun 12, 2017
Closed
@Tyriar Tyriar added the candidate Issue identified as probable candidate for fixing in the next release label Jun 12, 2017
@Tyriar
Copy link
Member Author

Tyriar commented Jun 12, 2017

Cherry picked to release/1.13

Tyriar added a commit that referenced this issue Jun 12, 2017
@Tyriar
Ensure pty gets resize event on layout
482968f 
Fixes #28138
This was referenced Jun 12, 2017
Closed
Closed
@aeschli aeschli added the verified Verification succeeded label Jun 14, 2017
@aeschli
Copy link
Contributor

aeschli commented Jun 14, 2017

Verified in 1.13.1

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Milestone
May Recovery 2017
Development

No branches or pull requests
2 participants
@Tyriar @aeschli