Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit Staged (Amend) asks for new commit message #35182

Closed
chrmarti opened this issue Sep 26, 2017 · 5 comments · Fixed by #38865 or #35403
Closed

Commit Staged (Amend) asks for new commit message #35182

chrmarti opened this issue Sep 26, 2017 · 5 comments · Fixed by #38865 or #35403
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities
Milestone

Comments

@chrmarti
Copy link
Collaborator

chrmarti commented Sep 26, 2017

  • VSCode Version: Code - Insiders 1.17.0-insider (a5210bc, 2017-09-26T05:24:48.911Z)
  • OS Version: Windows_NT x64 10.0.15063
  • Extensions: none

Testing #34963

Steps to Reproduce:

  1. Stage some change
  2. Commit Staged (Amend)
  3. 🐛 I'm asked for a new commit message without the existing one as the default. I usually want to keep the existing one.
@chrmarti chrmarti added the git GIT issues label Sep 26, 2017
@vscodebot vscodebot bot added the insiders label Sep 26, 2017
@joaomoreno joaomoreno added good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels Sep 27, 2017
@joaomoreno joaomoreno added this to the Backlog milestone Sep 27, 2017
@chrmarti chrmarti removed the insiders label Sep 27, 2017
@pradeepmurugesan
Copy link
Contributor

pradeepmurugesan commented Sep 29, 2017

@joaomoreno yeah may be we can add an option to keep the older message. I mean prefill the text box with the latest commit message..

@ADTC
Copy link

ADTC commented Dec 14, 2017

I'm assuming this is not in version 1.18.1.

Can I expect this in 1.18.2? Because I'm looking for this to amend the commit properly (both the diff and the message). I keep having to go back to the command line and issue git commit --amend because VSCode's Commit Staged (Amend) option shows a blank message.

@joaomoreno
Copy link
Member

No, this will be in 1.19.

@nzjony
Copy link

nzjony commented Dec 15, 2017

I upgrade to 1.19, and this works, however we use gerrit which has a Change-Id in the commit message, and the newline is removed when added to the commit message box. Which means when I upload the change to gerrit, it becomes a new patchset.
Can this please not remove the newlines.

@joaomoreno
Copy link
Member

I see... I created this to track that issue: #40295

@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Dec 15, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities
Projects
None yet
5 participants