Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide file icons per file type #4845

Closed
chrisxvin opened this issue Apr 1, 2016 · 15 comments · Fixed by #58795
Closed

Provide file icons per file type #4845

chrisxvin opened this issue Apr 1, 2016 · 15 comments · Fixed by #58795
Assignees
Labels
feature-request Request for new features or functionality icon-brand VS Code brand icon issues on-testplan ux User experience issues windows VS Code on Windows issues workbench-os-integration Native OS integration issues

Comments

@chrisxvin
Copy link

  • VSCode Version: Feb. stable build (0.10.11)
  • OS Version: Win 10 Pro

Steps to Reproduce:

  1. Install VSCode.
  2. See any code file in Explorer, icons are changed to vscode style, and cannot tell out C#/C++/H/etc...

Please add an option to choose whether to use VSCode file icon or not.

PS: This problem doesn't appears in insider build 0.10.13.

@joaomoreno
Copy link
Member

Brad can we get custom icons for each file type?

@bgashler1
Copy link
Contributor

@joaomoreno: Sure, we support numerous languages, though. Do we have a list of file associations that are affected so I can design just for those?

@chrisxvin
Copy link
Author

Well, I found again this problem on version 1.1.0-insider, build date 2016-5-9.
This time, C# file type associated with VSCode is set to "Visual Studio Code - Insiders", icons are all the same, :-( Can't tell it is a C# code file.
Screenshot is here:
image

@joaomoreno
Copy link
Member

Related to #7196

@joaomoreno
Copy link
Member

@chrisxvin, #7196 just got closed, so in the next update those Visual Studio Code - Insiders labels will get much more specific (e.g. C# Source File).

That should help a lot until we get the icons to really ice this cake off. 👍

@joaomoreno joaomoreno added ux User experience issues windows VS Code on Windows issues labels Jul 21, 2016
@mjbvz mjbvz assigned stevencl and unassigned bgashler1 Apr 11, 2017
@acmario
Copy link

acmario commented Oct 10, 2017

Any chance to have specific icons for each or at least main file types?

@bpasero bpasero added workbench-os-integration Native OS integration issues icon-brand VS Code brand icon issues labels Nov 11, 2017
@bpasero bpasero changed the title Icons in Windows Explorer are overrided Provide file icons per file type Nov 17, 2017
@bpasero bpasero added the feature-request Request for new features or functionality label Nov 17, 2017
@ashikns
Copy link

ashikns commented May 3, 2018

Is there any update on this? Or at least some extension or registry script I can use to achieve this?

@chrisdias chrisdias assigned miguelsolorio and unassigned chrisdias May 4, 2018
@miguelsolorio
Copy link
Contributor

miguelsolorio commented May 8, 2018

We're working on updating our file type icons that utilize the seti icons. There will be two icons at various sizes, the larger one will include the file type + vsc logo, the smaller one will only include the file type. Below is an example (on the mac) for both sizes:

Larger view
image

Smaller view
image

@bpasero
Copy link
Member

bpasero commented Aug 21, 2018

@misolori should we put this on the agenda again once we tackled Settings editor? Looks like we never really picked up on this.

@miguelsolorio
Copy link
Contributor

@bpasero yes, let's do this after the Settings editor.

@NavyAdmiral
Copy link

@misolori Will it be possible to provide an api/settings to change the icons that will be shipped on default by vscode? Letting extensions modify file icons per file type in Explorer would be great.

@miguelsolorio
Copy link
Contributor

@bpasero do we have a full list of all of the file types we'd want to support? The Seti theme has +160 file types, though a lot overlap:

@bpasero
Copy link
Member

bpasero commented Sep 7, 2018

@misolori maybe we limit this to the top file types users are using Code with and find a generic icon for the rest? Not sure we need all the file types?

@miguelsolorio
Copy link
Contributor

@bpasero I thought about maybe starting with the file types that appear in the Language Mode picker. But I’ll look through the telemetry we have for the top file types.

@bpasero
Copy link
Member

bpasero commented Sep 7, 2018

@misolori yeah that list is open ended though when you install extensions

@miguelsolorio miguelsolorio added this to the September 2018 milestone Sep 12, 2018
@bpasero bpasero self-assigned this Sep 17, 2018
bpasero added a commit that referenced this issue Sep 17, 2018
* first cut icons per file type (for #4845)

* update icon set

* update distro

* tweaks

* update distro
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 1, 2018
@bpasero bpasero removed their assignment Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality icon-brand VS Code brand icon issues on-testplan ux User experience issues windows VS Code on Windows issues workbench-os-integration Native OS integration issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants