Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webview editor doesn't appear in Open Previous Editor From History command #81824

Closed
alexr00 opened this issue Oct 2, 2019 · 0 comments · Fixed by #83019
Closed

Webview editor doesn't appear in Open Previous Editor From History command #81824

alexr00 opened this issue Oct 2, 2019 · 0 comments · Fixed by #83019
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded webview Webview issues
Milestone
October 2019

Comments

@alexr00
Copy link
Member

alexr00 commented Oct 2, 2019

Testing #81698

Open an image using the webview editor.
Open another editor.
Close the image.
Run the Open Previous Editor from History command.
Expected: I can re-open the image.
Actual: It's not listed as an option.
@mjbvz mjbvz added this to the October 2019 milestone Oct 2, 2019
@mjbvz mjbvz added the webview Webview issues label Oct 19, 2019
mjbvz added a commit to mjbvz/vscode that referenced this issue Oct 21, 2019
@mjbvz
Include custom editors in history
1f1654d 
Fixes microsoft#81824

The history service currently drops any editor input that are not `FileEditorInput`. This does not work for custom editors, which are always backed by a resource but do not subclass `FileEditorInput`

The fix here is to create history entries for any input that has a resource that is backed by the file-service
@mjbvz mjbvz mentioned this issue Oct 21, 2019
Merged
mjbvz added a commit that referenced this issue Oct 22, 2019
@mjbvz
Include custom editors in history (#83019)
9d752a2 
Fixes #81824

The history service currently drops any editor input that are not `FileEditorInput`. This does not work for custom editors, which are always backed by a resource but do not subclass `FileEditorInput`

The fix here is to create history entries for any input that has a resource that is backed by the file-service
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Oct 22, 2019
@bpasero bpasero added the verified Verification succeeded label Oct 31, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded webview Webview issues
Projects
None yet
Milestone
October 2019
Development

Successfully merging a pull request may close this issue.

Include custom editors in history mjbvz/vscode
3 participants
@bpasero @mjbvz @alexr00