Include custom editors in history #83019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft#81824 The history service currently drops any editor input that are not `FileEditorInput`. This does not work for custom editors, which are always backed by a resource but do not subclass `FileEditorInput` The fix here is to create history entries for any input that has a resource that is backed by the file-service
bpasero
approved these changes
Oct 22, 2019
|
Yeah, that is probably the right check to do. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81824
The history service currently drops any editor inputs that are not instances
FileEditorInput. This check does not work for custom editors, which are backed by resources like aFileEditorInputbut do not subclassFileEditorInputThis fix instead creates history entries for any input that has a resource that is backed by the file-service