Image preview should not zoom on first click if unfocused

[mjbvz]

Repo

1. Open an image to the side of a text editor
2. Start with the text editor focused
3. Now click into the image editor to focus it

Bug
The first click ends up zooming the image. Clicking should only zoom when the editor is already focused

[mjbvz]

Here's the relevant code about click handling in the image preview:

vscode/extensions/image-preview/media/main.js

Line 164 in 04d0cf6

container.addEventListener('click', (/** @type {MouseEvent} */ e) => {

[jeanp413]

If focus is required for zoom, then the cursor when hovering over the image preview should be the default arrow cursor when unfocused, currently it is the zoom-in cursor. Also zooming with the mouse wheel should not be allowed when unfocused. Thoughts?

[mjbvz]

Fixed by #82074

[alexr00]

I'm still seeing the first click zoom. Steps:

1. Open a typescript file.
2. Open a gif
3. Move gif to the right so that both typescript and gif are visible and side by side
4. Click in typescript.
5. Click in gif
   Expected: no zoom
   Actual: it zooms on the click in the gif in (5).

[MartinBrathen]

@alexr00 I'm not able to reproduce. Have tried on both insiders 1.40.0 and OSS.

Does this only occur with gifs for you?

[mjbvz]

I can repo this. You may need to click back and forth multiple times trigger the error

[MartinBrathen]

I'm still not able to. Will try more tomorrow.

A possible cause might be that the message event is fired before the mousedown event on the first click. This could be tested by checking the order of execution for the corresponding event handlers in /vscode/extensions/image-preview/media/main.js. I'll do it if I manage to reproduce the bug.