Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Image preview should not zoom on first click if unfocused #82074

Merged
merged 15 commits into from
Oct 14, 2019
Merged

Fixed: Image preview should not zoom on first click if unfocused #82074

merged 15 commits into from
Oct 14, 2019

Conversation

MartinBrathen
Copy link
Contributor

@mjbvz I believe this should solve issue #81877

@msftclas
Copy link

msftclas commented Oct 8, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@MartinBrathen MartinBrathen reopened this Oct 8, 2019
@MartinBrathen
Copy link
Contributor Author

Pressed the "Update branch" button, now test are not passing, will try to fix somehow.

@caiges caiges mentioned this pull request Oct 8, 2019
Closed
mjbvz
mjbvz requested changes Oct 8, 2019
View reviewed changes
extensions/image-preview/media/main.js Outdated Show resolved Hide resolved
extensions/image-preview/media/main.js Show resolved Hide resolved
extensions/image-preview/src/preview.ts Show resolved Hide resolved
@MartinBrathen
Copy link
Contributor Author

I removed an unnecessary state variable.

In this branch I removed the 'mousedown' listener and the usage of message passing as well. Sadly it introduces a bug where the user has to click twice if the image preview is not focused by clicking on the preview. I do not currently know of a way to check how the preview was focused.

@mjbvz mjbvz added this to the October 2019 milestone Oct 14, 2019
@mjbvz mjbvz mentioned this pull request Oct 14, 2019
Closed
@mjbvz mjbvz merged commit 9048856 into microsoft:master Oct 14, 2019
@mjbvz
Copy link
Collaborator

mjbvz commented Oct 14, 2019

Thanks! Will be in the next insiders build and is scheduled to go out with VS Code 1.40

@mjbvz mjbvz mentioned this pull request Oct 14, 2019
Closed
@MartinBrathen
Copy link
Contributor Author

Cool! Thank you :)

@MartinBrathen MartinBrathen mentioned this pull request Nov 1, 2019
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mjbvz mjbvz Awaiting requested review from mjbvz

Assignees

@mjbvz mjbvz

Labels
None yet
Projects
None yet
Milestone
October 2019
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinBrathen @msftclas @mjbvz