Fix-81877 Image preview should not zoom on first click if unfocused #81935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I opened a PR yesterday for this but forgot to link the issue, #81933 to my PR. I took a similar approach. It doesn't appear to be possible to query for whether the current view is active -- |
|
@mjbvz , Any updates on this ? |
|
Hey sorry for the delay. A few other people also jumped on the issue before I could unmark it as help wanted and those PRs also handled a few important additional cases, such as when the preview is unfocused an refocused after the initial load I'm close this PR in favor of #82074 but the feature will be making it into the next release |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mjbvz , Here is the fix for #81877 .
I am not sure if this is the solution you wanted but just wanted to know if this is towards the right direction. ( Because you have mentioned about focus , I am not quite sure how to get that info here )
Thanks :)