Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command line error - "Option 'proxy-server' is unknown. Ignoring." #82253

Closed
astrowonk opened this issue Oct 10, 2019 · 3 comments
Closed

Command line error - "Option 'proxy-server' is unknown. Ignoring." #82253

astrowonk opened this issue Oct 10, 2019 · 3 comments
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded workbench-cli VS Code Command line issues
Milestone
September 2019 Re...

Comments

@astrowonk
Copy link

astrowonk commented Oct 10, 2019 •
edited
Loading

  • VSCode Version: 1.39.0
  • OS Version: Linux RHEL 7

Steps to Reproduce:

  1. Launch code with --no-proxy-server flag
  2. "Option 'proxy-server' is unknown. Ignoring." error appears.

I think the proxy is still disabled, the error message is simply wrong? If I run without the flag, I get prompted to log into the proxy, if I run with the flag, the proxy appears disabled (no log in prompting) but the error appears on the command line.
@joaomoreno joaomoreno assigned aeschli and unassigned joaomoreno Oct 11, 2019
aeschli added a commit that referenced this issue Oct 14, 2019
@aeschli
Command line error - "Option 'proxy-server' is unknown. Ignoring.". F…
b9dc1ce 
…ixes #82253
@aeschli aeschli mentioned this issue Oct 14, 2019
Merged
@aeschli aeschli added this to the September 2019 Recovery 2 milestone Oct 14, 2019
@aeschli aeschli added the workbench-cli VS Code Command line issues label Oct 14, 2019
@aeschli aeschli reopened this Oct 14, 2019
@aeschli aeschli added the candidate Issue identified as probable candidate for fixing in the next release label Oct 14, 2019
@aeschli
Copy link
Contributor

aeschli commented Oct 14, 2019

I suggest to include that fix in the recovery builds to avoid any confusion due to the message printed by the cli.
The cli says Option 'xy' is unknown. Ignoring. for all chromium options, but in fact, they are used. My understanding is that most of the chromium options are not for the end-user except --inspect and the proxy settings, so I added these to the list of the valid (supported) args. @joaomoreno @bpasero Please speak up if I missed one of the options.
PR is #82486

@egamma egamma closed this as completed in 03dd464 Oct 14, 2019
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Oct 15, 2019
@alexdima
Copy link
Member

alexdima commented Oct 15, 2019 •
edited
Loading

This is not fixed in the latest stable release candidate. The reason is that the PR was actually not merged and this issue was closed erroneously

@alexdima alexdima reopened this Oct 15, 2019
@alexdima alexdima added the verification-found Issue verification failed label Oct 15, 2019
@alexdima
Copy link
Member

The discussion in yesterday's standup was to take this, so we've now merged the PR...

@alexdima alexdima added verified Verification succeeded and removed verification-found Issue verification failed labels Oct 15, 2019
@jscombs91 jscombs91 mentioned this issue Nov 13, 2019
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded workbench-cli VS Code Command line issues
Projects
None yet
Milestone
September 2019 Recovery 2
Development

No branches or pull requests
4 participants
@joaomoreno @alexdima @aeschli @astrowonk