Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chromium command line args #82486

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Add chromium command line args #82486

merged 1 commit into from
Oct 15, 2019

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented Oct 14, 2019 •
edited
Loading

Fixes #82253 in 1.39

See #82253 (comment) for reasoning.

@aeschli aeschli added this to the September 2019 Recovery 2 milestone Oct 14, 2019
@aeschli aeschli self-assigned this Oct 14, 2019
@aeschli aeschli added the workbench-cli VS Code Command line issues label Oct 14, 2019
@aeschli aeschli mentioned this pull request Oct 14, 2019
Closed
@aeschli aeschli changed the title Add chromium command line args #82253 Add chromium command line args Oct 14, 2019
@bpasero
Copy link
Member

bpasero commented Oct 14, 2019

I think 1 approval is good enough.

@bpasero bpasero removed their request for review October 14, 2019 14:20
@joaomoreno joaomoreno merged commit 6ab5985 into release/1.39 Oct 15, 2019
@joaomoreno joaomoreno deleted the aeschli/add-chromium-args branch October 15, 2019 15:03
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaomoreno joaomoreno joaomoreno approved these changes

Assignees

@aeschli aeschli

Labels
workbench-cli VS Code Command line issues
Projects
None yet
Milestone
September 2019 Recovery 2
Development

Successfully merging this pull request may close these issues.
3 participants
@aeschli @bpasero @joaomoreno