Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panel sash: Invalid location: Error: Invalid location #86033

Closed
isidorn opened this issue Dec 3, 2019 · 0 comments
Closed

Panel sash: Invalid location: Error: Invalid location #86033

isidorn opened this issue Dec 3, 2019 · 0 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues verified Verification succeeded
Milestone
January 2020

Comments

@isidorn
Copy link
Contributor

isidorn commented Dec 3, 2019

Refs: #85908

  1. Have panel open, have sidebar open
  2. Move sidebar from left to right, or from right to left
  3. Double click on the panel sash. Get the following exception:

I can repro with insiders, so not directly tied to your refactorings

 ERR Invalid location: Error: Invalid location
    at GridView.getNode (file:///Users/isidor/Development/vscode/out/vs/base/browser/ui/grid/gridview.js:794:23)
    at GridView.getNode (file:///Users/isidor/Development/vscode/out/vs/base/browser/ui/grid/gridview.js:802:25)
    at GridView.getNode (file:///Users/isidor/Development/vscode/out/vs/base/browser/ui/grid/gridview.js:802:25)
    at GridView.getView (file:///Users/isidor/Development/vscode/out/vs/base/browser/ui/grid/gridview.js:737:42)
    at resizeToPreferredSize (file:///Users/isidor/Development/vscode/out/vs/base/browser/ui/grid/grid.js:333:44)
    at SerializableGrid.onDidSashReset (file:///Users/isidor/Development/vscode/out/vs/base/browser/ui/grid/grid.js:346:17)
    at Emitter.fire (file:///Users/isidor/Development/vscode/out/vs/base/common/event.js:461:41)
    at Emitter.fire (file:///Users/isidor/Development/vscode/out/vs/base/common/event.js:461:41)
    at file:///Users/isidor/Development/vscode/out/vs/base/common/event.js:70:138
    at Emitter.fire (file:///Users/isidor/Development/vscode/out/vs/base/common/event.js:458:38)
    at file:///Users/isidor/Development/vscode/out/vs/base/common/event.js:43:93
    at Emitter.fire (file:///Users/isidor/Development/vscode/out/vs/base/common/event.js:458:38)
    at file:///Users/isidor/Development/vscode/out/vs/base/common/event.js:70:138
    at Emitter.fire (file:///Users/isidor/Development/vscode/out/vs/base/common/event.js:458:38)
    at file:///Users/isidor/Development/vscode/out/vs/base/common/event.js:43:93
    at Emitter.fire (file:///Users/isidor/Development/vscode/out/vs/base/common/event.js:458:38)
    at Emitter.fire (file:///Users/isidor/Development/vscode/out/vs/base/common/event.js:461:41)
    at file:///Users/isidor/Development/vscode/out/vs/base/common/event.js:43:93
    at Emitter.fire (file:///Users/isidor/Development/vscode/out/vs/base/common/event.js:458:38)
    at file:///Users/isidor/Development/vscode/out/vs/base/browser/ui/splitview/splitview.js:511:42
    at Emitter.fire (file:///Users/isidor/Development/vscode/out/vs/base/common/event.js:458:38)
    at Sash.onMouseDoubleClick (file:///Users/isidor/Development/vscode/out/vs/base/browser/ui/sash/sash.js:203:30)
    at Emitter.fire (file:///Users/isidor/Development/vscode/out/vs/base/common/event.js:461:41)
    at HTMLDivElement.fn (file:///Users/isidor/Development/vscode/out/vs/base/browser/event.js:9:35)
@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues labels Dec 3, 2019
@sbatten sbatten added this to the On Deck milestone Dec 3, 2019
jeanp413 added a commit to jeanp413/vscode that referenced this issue Dec 7, 2019
@jeanp413
Fixes microsoft#86033
a97b145
@jeanp413 jeanp413 mentioned this issue Dec 7, 2019
Closed
@joaomoreno joaomoreno assigned joaomoreno and unassigned sbatten Jan 15, 2020
@joaomoreno joaomoreno modified the milestones: On Deck, January 2020 Jan 15, 2020
@isidorn isidorn added the verified Verification succeeded label Jan 28, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues verified Verification succeeded
Projects
None yet
Milestone
January 2020
Development

Successfully merging a pull request may close this issue.

Fixes panel sash: Invalid location: Error: Invalid location jeanp413/vscode
3 participants
@joaomoreno @isidorn @sbatten