Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Viewlet/ViewContainer Refactor #85908

Closed
2 tasks done
sbatten opened this issue Dec 2, 2019 · 2 comments
Closed
2 tasks done

Test: Viewlet/ViewContainer Refactor #85908

sbatten opened this issue Dec 2, 2019 · 2 comments

Comments

@sbatten
Copy link
Member

sbatten commented Dec 2, 2019

Refs #85566

Complexity: 3

Test the branch for the PR to ensure there are no regressions introduced so that we can be in a great starting state for next iteration.

@sbatten sbatten added this to the November 2019 milestone Dec 2, 2019
@isidorn
Copy link
Contributor

isidorn commented Dec 2, 2019

Sounds good. Imho this touches a lot of areas and will require a bit more time, thus increasing complexity to 3.

@isidorn
Copy link
Contributor

isidorn commented Dec 3, 2019

Great work. I could find some issues, but they were mostly present before your refactoring.

@isidorn isidorn removed their assignment Dec 3, 2019
@sandy081 sandy081 removed their assignment Dec 3, 2019
@sandy081 sandy081 closed this as completed Dec 3, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants