-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viewlet Refactor #85566
Viewlet Refactor #85566
Conversation
@sbatten the changes you outlined here make a lot of sense to me. |
@stevencl I went through the changes and they all looks good to me over all. I did a quick testing and found following
Otherwise most of the features are working good. 👏 |
@stevencl let me know if you would like me to test this out. Or even better create a test plan item and assign me to it. |
Yes! Sorry for the ping Steven Clarke :) |
@sandy081 updated to fixes the issues you found. This PR will be checked in when master opens after endgame testing. I'll keep in up to date with master as necessary. Let's use an endgame test plan item (I will create and assign) to harden. |
That issue is also not specific to my branch. Since there are no more issue specific to my branch and this has gone through an endgame review, I will merge to avoid more conflicts. If you have additional feedback, we can add it straight to master. |
This PR refs #85164
The goal of this PR is to refactor the Viewlet structure so that code useful to enhancing panels in the same way is separated from the Viewlet inheritance path.
This PR
PaneComposite
,ViewPaneContainer
.ViewPaneContainer
encapsulates theSplitView
andView
management behavior currently unique toViewlet
in a standalone class. As a derived class ofComposite
,PaneComposite
composesViewPaneContainer
allowing this enhancement behavior to be shared betweenViewlet
andPanel
.Viewlet
s, (e.g. Explorer), to extend fromViewPaneContainer
. The goal is to makeViewPaneContainer
implementations agnostic of theirComposite
container (Panel
orViewlet
).Viewlet
classes for each existingViewlet
to instantiate the newViewPaneContainer
.ViewletPane
toViewPane