Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle tree data provider error in getChildren #170698

Merged
merged 4 commits into from
Jan 6, 2023
Merged

Handle tree data provider error in getChildren #170698

merged 4 commits into from
Jan 6, 2023

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Jan 6, 2023

@alexr00 alexr00 enabled auto-merge (squash) January 6, 2023 15:36
@alexr00 alexr00 self-assigned this Jan 6, 2023
@vscodenpa vscodenpa added this to the January 2023 milestone Jan 6, 2023
hediet
hediet requested changes Jan 6, 2023
View reviewed changes
Copy link
Member

@hediet hediet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment. I think catch all clauses should be avoided as much as possible.

@alexr00 alexr00 requested a review from hediet January 6, 2023 16:40
@alexr00 alexr00 merged commit c12209a into main Jan 6, 2023
@alexr00 alexr00 deleted the alexr00/issue4002_1 branch January 6, 2023 16:58
@alexr00 alexr00 mentioned this pull request Jan 11, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hediet hediet hediet approved these changes

Assignees

@alexr00 alexr00

Labels
None yet
Projects
None yet
Milestone
January 2023
Development

Successfully merging this pull request may close these issues.

"No tree view with id 'github:compareChanges' registered" after opening PR
3 participants
@alexr00 @hediet @vscodenpa