Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"No tree view with id 'github:compareChanges' registered" after opening PR #4002

Closed
rzhao271 opened this issue Sep 29, 2022 · 9 comments · Fixed by microsoft/vscode#165087, microsoft/vscode#170698 or microsoft/vscode#180415
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@rzhao271
Copy link
Contributor

Testing #3985

After I created the PR, I got the error "No tree view with id 'github:compareChanges' registered."

I think these logs are related:

[Debug 1664465581.808s] PullRequestTree> Creating file and commit nodes for PR #2
[Debug 1664465582.89s] PullRequestOverviewPanel> pr.initialize
[Debug 1664465583.06s] PullRequestChangesTreeDataProvider> Error: TreeError [prStatus:github] Tree element not found: [object Object]
@rzhao271 rzhao271 changed the title No tree view with compareChanges registered after opening PR "No tree view with id 'github:compareChanges' registered" after opening PR Sep 29, 2022
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Sep 29, 2022
@alexr00 alexr00 added this to the October 2022 milestone Sep 29, 2022
@alexr00
Copy link
Member

alexr00 commented Oct 24, 2022

Next time you see this can you grab the full stack for "No tree view with id 'github:compareChanges' registered." from the dev tools?

@alexr00 alexr00 added the info-needed Issue requires more information from poster label Oct 24, 2022
@alexr00 alexr00 removed this from the October 2022 milestone Oct 24, 2022
@roblourens
Copy link
Member

Been seeing this often lately

No tree view with id 'github:compareChanges' registered.: Error: No tree view with id 'github:compareChanges' registered.
    at f.$setVisible (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:112:13758)
    at l._doInvokeHandler (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:101:13680)
    at l._invokeHandler (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:101:13362)
    at l._receiveRequest (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:101:12132)
    at l._receiveOneMessage (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:101:10834)
    at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:101:8941
    at h.invoke (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:61:145)
    at v.deliver (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:61:2266)
    at g.fire (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:61:1844)
    at r.fire (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:69:19049)
    at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:117:17104
    at h.invoke (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:61:145)
    at v.deliver (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:61:2266)
    at g.fire (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:61:1844)
    at r.fire (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:69:19049)
    at MessagePortMain.<anonymous> (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:117:15144)
    at MessagePortMain.emit (node:events:526:28)
    at Object.MessagePortMain._internalPort.emit (node:electron/js2c/utility_process_init:5:364)

@alexr00 alexr00 added this to the November 2022 milestone Oct 25, 2022
@joyceerhl
Copy link
Contributor

joyceerhl commented Oct 28, 2022

I also see this (specifically I see it all the time in codespaces) and there's an additional callstack

notificationsAlerts.ts:40 Error: No tree view with id 'github:compareChanges' registered.
	at f.$getChildren (vscode-file://vscode-app/vscode/bin/linux-x64/2ada565d06c2decc0c14af3f2289ee1ca7fed830-insider/out/vs/workbench/api/node/extensionHostProcess.js:113:12230)
	at l._doInvokeHandler (vscode-file://vscode-app/vscode/bin/linux-x64/2ada565d06c2decc0c14af3f2289ee1ca7fed830-insider/out/vs/workbench/api/node/extensionHostProcess.js:102:13680)
	at l._invokeHandler (vscode-file://vscode-app/vscode/bin/linux-x64/2ada565d06c2decc0c14af3f2289ee1ca7fed830-insider/out/vs/workbench/api/node/extensionHostProcess.js:102:13362)
	at l._receiveRequest (vscode-file://vscode-app/vscode/bin/linux-x64/2ada565d06c2decc0c14af3f2289ee1ca7fed830-insider/out/vs/workbench/api/node/extensionHostProcess.js:102:12132)
	at l._receiveOneMessage (vscode-file://vscode-app/vscode/bin/linux-x64/2ada565d06c2decc0c14af3f2289ee1ca7fed830-insider/out/vs/workbench/api/node/extensionHostProcess.js:102:11033)
	at vscode-file://vscode-app/vscode/bin/linux-x64/2ada565d06c2decc0c14af3f2289ee1ca7fed830-insider/out/vs/workbench/api/node/extensionHostProcess.js:102:8941
	at h.invoke (vscode-file://vscode-app/vscode/bin/linux-x64/2ada565d06c2decc0c14af3f2289ee1ca7fed830-insider/out/vs/workbench/api/node/extensionHostProcess.js:61:145)
	at v.deliver (vscode-file://vscode-app/vscode/bin/linux-x64/2ada565d06c2decc0c14af3f2289ee1ca7fed830-insider/out/vs/workbench/api/node/extensionHostProcess.js:61:2266)
	at g.fire (vscode-file://vscode-app/vscode/bin/linux-x64/2ada565d06c2decc0c14af3f2289ee1ca7fed830-insider/out/vs/workbench/api/node/extensionHostProcess.js:61:1844)
	at r.fire (vscode-file://vscode-app/vscode/bin/linux-x64/2ada565d06c2decc0c14af3f2289ee1ca7fed830-insider/out/vs/workbench/api/node/extensionHostProcess.js:70:16515)
	at vscode-file://vscode-app/vscode/bin/linux-x64/2ada565d06c2decc0c14af3f2289ee1ca7fed830-insider/out/vs/workbench/api/node/extensionHostProcess.js:118:17104
	at h.invoke (vscode-file://vscode-app/vscode/bin/linux-x64/2ada565d06c2decc0c14af3f2289ee1ca7fed830-insider/out/vs/workbench/api/node/extensionHostProcess.js:61:145)
	at v.deliver (vscode-file://vscode-app/vscode/bin/linux-x64/2ada565d06c2decc0c14af3f2289ee1ca7fed830-insider/out/vs/workbench/api/node/extensionHostProcess.js:61:2266)
	at g.fire (vscode-file://vscode-app/vscode/bin/linux-x64/2ada565d06c2decc0c14af3f2289ee1ca7fed830-insider/out/vs/workbench/api/node/extensionHostProcess.js:61:1844)
	at r.fire (vscode-file://vscode-app/vscode/bin/linux-x64/2ada565d06c2decc0c14af3f2289ee1ca7fed830-insider/out/vs/workbench/api/node/extensionHostProcess.js:70:16515)
	at o._receiveMessage (vscode-file://vscode-app/vscode/bin/linux-x64/2ada565d06c2decc0c14af3f2289ee1ca7fed830-insider/out/vs/workbench/api/node/extensionHostProcess.js:70:21327)
	at vscode-file://vscode-app/vscode/bin/linux-x64/2ada565d06c2decc0c14af3f2289ee1ca7fed830-insider/out/vs/workbench/api/node/extensionHostProcess.js:70:18770
	at h.invoke (vscode-file://vscode-app/vscode/bin/linux-x64/2ada565d06c2decc0c14af3f2289ee1ca7fed830-insider/out/vs/workbench/api/node/extensionHostProcess.js:61:145)
	at v.deliver (vscode-file://vscode-app/vscode/bin/linux-x64/2ada565d06c2decc0c14af3f2289ee1ca7fed830-insider/out/vs/workbench/api/node/extensionHostProcess.js:61:2266)
	at g.fire (vscode-file://vscode-app/vscode/bin/linux-x64/2ada565d06c2decc0c14af3f2289ee1ca7fed830-insider/out/vs/workbench/api/node/extensionHostProcess.js:61:1844)
	at g.acceptChunk (vscode-file://vscode-app/vscode/bin/linux-x64/2ada565d06c2decc0c14af3f2289ee1ca7fed830-insider/out/vs/workbench/api/node/extensionHostProcess.js:70:13346)
	at vscode-file://vscode-app/vscode/bin/linux-x64/2ada565d06c2decc0c14af3f2289ee1ca7fed830-insider/out/vs/workbench/api/node/extensionHostProcess.js:70:12476
	at h.invoke (vscode-file://vscode-app/vscode/bin/linux-x64/2ada565d06c2decc0c14af3f2289ee1ca7fed830-insider/out/vs/workbench/api/node/extensionHostProcess.js:61:145)
	at v.deliver (vscode-file://vscode-app/vscode/bin/linux-x64/2ada565d06c2decc0c14af3f2289ee1ca7fed830-insider/out/vs/workbench/api/node/extensionHostProcess.js:61:2266)
	at g.fire (vscode-file://vscode-app/vscode/bin/linux-x64/2ada565d06c2decc0c14af3f2289ee1ca7fed830-insider/out/vs/workbench/api/node/extensionHostProcess.js:61:1844)
	at g._processReadQueue (vscode-file://vscode-app/vscode/bin/linux-x64/2ada565d06c2decc0c14af3f2289ee1ca7fed830-insider/out/vs/workbench/api/node/extensionHostProcess.js:70:32010)

@alexr00 alexr00 removed the info-needed Issue requires more information from poster label Oct 28, 2022
alexr00 added a commit to microsoft/vscode that referenced this issue Nov 1, 2022
* Fix tree data provider being accessed after disposed
Fixes microsoft/vscode-pull-request-github#4002

* Use setTimeout0
KendallDoesCoding pushed a commit to KendallDoesCoding/vscode that referenced this issue Nov 5, 2022
* `collapseByDefault` for notebook should also honor new setting

fixes microsoft#164542

* Tunnel: Fix host name issue (microsoft#164708)

* tunnel: Generate vanity URL (microsoft#164710)

* fix microsoft#164458 (microsoft#164711)

* Fix microsoft#164606 (microsoft#164714)

* Fix microsoft#164617 (microsoft#164717)

* Transform ext host log URI on remote side (microsoft#164712)

* Transform ext host log URI on remote side

* Fix mistype

* Allow action labels to be long in comment header (microsoft#164614)

* Allow action labels to be long in comment header
Part of microsoft#164288

* Better fix

* Fix microsoft#163163 (microsoft#164721)

* Fix microsoft#162240 (microsoft#164723)

* Fix microsoft#162439 (microsoft#164719)

* Fix microsoft#162439

* better fix and also add tests

* Move log message outside of 'if' block so I have confirmation that smoething happened

* Re microsoft#164715. Better error handling of notebook opening (microsoft#164737)

* Fix microsoft#164704. comment thread memory leak. (microsoft#164734)

* Fix microsoft#164704. comment thread memory leak.

* Dispose first.

* spell check

* Use `border-radius: 2px` (microsoft#164747)

Fixes microsoft#164555: Use `border-radius: 2px`

* Do not adjust y offset when the mouse is below the last line (microsoft#164750)

Fixes microsoft#164131: Do not adjust y offset when the mouse is below the last line

* tunnel --name should rename previous tunnel (microsoft#164753)

* tunnel --name should rename old tunnel

* fix clippy warning

* Fix markdown server not updating documents properly on folder rename (microsoft#164752)

Fixes microsoft#164562

* Fix microsoft#164715. Turn cell into editing mode when there is a selection. (microsoft#164758)

* Add min-height to work around clipping (microsoft#164759)

Fixes microsoft#164602

* Shorten markdown link button titles (microsoft#164764)

Fixes microsoft#164556

* Pick up latest markdown LS (microsoft#164763)

Includes a few more fixes for link update on rename

* Clean up a few markdown setting descriptions (microsoft#164765)

Clean up wording and make sure we use `Markdown` uppercase

* Rework markdown update link glob (microsoft#164766)

* Rework markdown update link glob

Fixes microsoft#164587

This changes the `externalFileGlobs` setting to instead be a include array of globs that should trigger link updates. I've split the globs into markdown files and image/video files

This also makes it easier for users to add their own new globs to the list

* Fix scopes

* Store edit session before prompting to select edit session destination (microsoft#164780)

* Don't ship yarn.lock file with the markdown extension (microsoft#164794)

* Always patch the npm registry in `yarn.lock` files and compute the node modules cache key after having patched them (microsoft#164795)

* Fixes microsoft#163931 (microsoft#164802)

* fix name of profile tmp-file (microsoft#164805)

* make sure `startup.resource.perf` doesn't contain paths (microsoft#164812)

* make sure `startup.resource.perf` doesn't contain paths

microsoft#164810

* use posix.basename...

* Quick check to circumvent regex in many cases (microsoft#164815)

* Quick check to circumvent regex in many cases

* Fix logic

* Fix .ipynb extension name capitalization (microsoft#164817)

Towards microsoft/vscode-jupyter#11773

* Bump distro (microsoft#164821)

* Use posix path for markdown links (microsoft#164822)

Fixes microsoft#164782

* Fix markdown document deleting (microsoft#164829)

Fixes microsoft#164562

My previous fix was incorrect as it checked if the document existed by still consulting our `_documentCache`. When we are deleting/renaming an opened md document, it should pretty much always exist in our cache

The fix is to instead treat `this.documents` and the file system as the source of truth when determining if the doc should be deleted or not

* Disable markdown insert link commands in readonly editors (microsoft#164820)

Disable insert link commands in readonly editors

* Skip clear if there is nothing in the actionbar list (microsoft#164839)

* Engineering - Empty commit (microsoft#164850)

Empty commit

* Engineering - Add quality in the build name (microsoft#164855)

Add quality in the build name

* Fix text of IW command palette entries (microsoft#164860)

* chore: update electron@19.1.3 (microsoft#164864)

* Use simple `IAction` instead of `Action`in quick input (microsoft#164842)

For actions that are static, it is better to use `IAction`. This avoids creating an extra disposable, emitter, and event listener (when used with an action bar)

This is helpful in the quick input list as we need to render elements rapidly while scrolling

* Engineering - adopt l10n for git-base/git/github extesions (microsoft#164566)

Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com>

* 💄 Banner - remove registerThemingParticipant (microsoft#164879)

* Commit Action button polish (microsoft#164746)

* * force the use of `InstantiationType` * mark all standalone editor services as eager * mark remaining extension host services as eager (microsoft#164883)

* force the use of `InstantiationType`
* mark all standalone editor services as eager
* mark remaining extension host services as eager

* perf - ignore new listeners when leakage threshold is exceeded by far (microsoft#164885)

* debt - extract outline actions and outline interfaces into separate files (microsoft#164887)

* chore: update electron@19.1.3 (microsoft#164882)

* chore: update electron@19.1.3

* fix: update api name

* 💄 Diff decorators - remove registerThemingParticipant (microsoft#164889)

* 💄 use event naming conventions for EmitterOptions (microsoft#164890)

* avoid object-spread in perf-critical code, use `Object.assign`-instead (microsoft#164892)

* Use `IAction` instead of `Action` for search item action (microsoft#164844)

For actions that are static, it is better to use `IAction` instead of `Action`. This avoids creating an extra disposable, emitter, and event listener (when used with an action bar). It also means you don't have to dispose of the action

This small optimization is useful here because we create one of these actions for every search item in the list as you scroll

* Defer creation of `monaco-icon-description-container` (microsoft#164659)

We don't need to create the `monaco-icon-description-container` container until the description is actually needed. In many cases it is never filled in, so we can skip creating this empty node

* Swap list/tree icons to reflect current state instead of target state  (microsoft#164835)

* Swap search result tree/list view icons

* Swap SCM list/tree view icons

* Sort the keys in order to be more predictable (microsoft#164920)

sort the keys in order to be more predictable

* Fix timeline not disposing of template properly (microsoft#164838)

We should dispose the entire template, not just the `iconLabel`

* Remove exports of unused types (microsoft#164943)

For microsoft#164939

* Don't export `SelectKernelReturnArgs` (microsoft#164944)

* Fix bugs with close of markdown docs (microsoft#164942)

There are two bugs here:

- Something in the lsp is converting a value from `undefined` to `null`. To fix this, I've updated us just to check for falsy values instead
- The `hasInMemoryDoc` implementation was incorrect. It needs to verify that the value of `this.inMemoryDoc` is not null/undefined

* Pick up latest markdown LS (microsoft#164945)

Picks up microsoft/vscode-markdown-languageservice#84

* bump unique names generator (microsoft#165015)

* 💄 SCM - Remove registerThemingParticipant (microsoft#165038)

* SCM - adopt more theme variables

* Remove registerThemingParticipant

* unexport createDecorator (microsoft#165039)

related to microsoft#164938

* Remove inlineCompletionsNew proposal. Fixes microsoft#164856 (microsoft#165044)

* SCM - fix action button border (microsoft#165048)

Fix regression

* Implements microsoft#164686

* Only export symbols that are needed (microsoft#165052)

* Fixes microsoft#164934: Only export symbols that are needed

* `KeyMod` is referenced by `monaco.d.ts`

* Add email attachments are lost on Github (microsoft#165057)

Add email attachments are lost Github

* Show progress when storing edit session as part of Continue On flow (microsoft#164903)

* Show progress when storing edit session as part of Continue On flow

* Port release fix

* update notebook milestones (microsoft#165064)

* Remove exports and unused types (microsoft#164939) (microsoft#165065)

* Updates custom menu borders and item styles (microsoft#164165)

Updates menu item margin and radius and adds border to default themes

* improve title bar settings for web (microsoft#165068)

fixes microsoft#164768

* use updated private API name (microsoft#165069)

fix microsoft#164899

* Pick up latest TS for VS Code (microsoft#165075)

* Remove unused import for notebook background (microsoft#165070)

* remove some of listed unused imports

* Adopt notebook serializer for test (microsoft#165078)

For microsoft#160580

* GitHub Enterprise Auth improvements (microsoft#165082)

1. Namespace secrets based on the value of github-enterprise.uri to support "multiple separate GHES instances"
2. If the setting value disappears, continue using last set value. Fixes microsoft/vscode-pull-request-github#3992
3. Mark github-enterprise.uri as requires trust
3. Refactoring like:
  * UriHandler is handled in extension.ts and passed down everywhere since we can only have 1 instance of it
  * misc style (`private` usage, better `disposable` handling)

* Adopt notebook serializer for notebook document tests (microsoft#165081)

For microsoft#160580

Also remove one test that is no longer relevant

* Adopt prefix private with _ in markdown extension (microsoft#165088)

* Bump version for Nov. (microsoft#165091)

* Improve log message for aborting resuming an edit session (microsoft#165108)

* Pick up latest markdown language service (microsoft#165093)

* fix microsoft#154064 which was running the wrong taskgroups (microsoft#164983)

* add trace logs for search parent debug (microsoft#165095)

* add trace logs for search parent debug

* Remove a few `export`s (microsoft#165106)

Ref microsoft#164941

* Fix microsoft#164630 (microsoft#165096)

* The true fix

* some code clean up

* Revert "Bump version for Nov. (microsoft#165091)" (microsoft#165118)

This reverts commit 8b4642a.

This seems to be causing our builds to fail: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=191117&view=logs&j=4801dce2-64f3-53d6-b366-d49a1977c639&t=d3816dfe-5f5f-5b74-f77f-0a43291213b6&l=22

* Remove the 🥕 since we have modes in the go to file (microsoft#164437)

Fixes microsoft#163957

* Pick up latest TS for building VS Code (microsoft#165104)

* Pick up latest TS for building VS Code

* Pick up latest node typings

* Bump node types

* Reduce unused exports (microsoft#164935)

* Update to current Devcontainer extension image link (microsoft#163557)

* fix inno setup build for non-insider qualities (microsoft#165143)

fixes microsoft#165142

* add 🚀 build tag to builds which go through publishing (microsoft#165145)

* skip flaky test (microsoft#165150)

* skip flaky test

related to microsoft#165149

* skip the entire suite

* smoketests should not fail by bumping version in package.json (microsoft#165132)

related to microsoft#165118

* bump version (microsoft#165133)

* Update grammars (microsoft#165100)

* fix Alpine builds with npm custom registry (microsoft#165137)

fixes microsoft#165135

* api feedback (microsoft#164470)

* api feedback
- remove critical log level
- move log level off to be 0

* handle off log level

* fix disabling log level in tests

Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>

* Highlight label should not create extra span nodes (microsoft#164657)

* Highlight label should not create extra empty dom nodes

I noticed that the `HighlightedLabel` class creates extra `span` elements for text ranges. These should not be needed. Using text children directly should be faster for creation and also reduce the number of nodes in the document

I also related the conditional spread with a longer version that uses a simple call to push. This is worth doing since `HighlightedLabel` is so widely used in the editor

* Update tests

* Update smoke test selector

* Update css

* lramos15/xenacious-bedbug (microsoft#165083)

* Don't shortcircuit active editor in Resolver

* Fix broken test

* debt - use CSS variables instead of `registerThemingParticipant` (microsoft#165164)

* Fixes task reconnection status does not work for default build task (microsoft#165110)

Fixes microsoft#159639

Co-authored-by: Megan Rogge <merogge@microsoft.com>

* a11y issues to Megan (microsoft#165166)

* More unused exports (microsoft#165167)

For microsoft#164939

* Clean up some unused exports (microsoft#165107)

For microsoft#164937

* Fix tree data provider being accessed after disposed (microsoft#165087)

* Fix tree data provider being accessed after disposed
Fixes microsoft/vscode-pull-request-github#4002

* Use setTimeout0

* use ctxt menu event for all actBar context menus (microsoft#165177)

fixes microsoft#163247

* Remove a few `export`s (microsoft#165158)

* Remove a few `export`s

* don't omit indirect exports

* Remove unneeded `export` (microsoft#165178)

Part of microsoft#164933

* Use `_` for privates in webview code (microsoft#165183)

* only renderBody when view is visible/expanded (microsoft#165187)

fixes PaneView calls renderBody even when the pane is collapsed microsoft#164662

* prevent `.zshenv` recursion (microsoft#165174)

fix microsoft#163843

* Use css vars for lightbulb (microsoft#165186)

Fixes microsoft#165169

* Limit shifting (microsoft#165141)

* Do not render synchronously when restoring the state, the desired `scrollLeft` is maintained even if the `scrollWidth` is small (microsoft#165193)

* use != operator instead of -ne (microsoft#165191)

use != operator

* Audio Cues: Don't play the same sound in parallel. Fixes microsoft#164921 (microsoft#165194)

* re microsoft#164939. reduced unused exports. (microsoft#165196)

* re microsoft#164939. reduced unused exports in notebook worker. (microsoft#165198)

* Markdown lang preview settings description (microsoft#165109)

* Change descriptions to just say “Enable…”

Previously these said “Enable or disable…”, which in the context of a tick box doesn’t make sense.

* Change “Enable/disable” wording in descriptions

* webview: ignore Ctrl+W and Ctrl+N in webview for PWA (microsoft#164981)

This fixes closing Release Notes / Markdown Preview with Ctrl+W closing whole PWA.

PWAs can intercept the Ctrl+W/Ctrl+N keystrokes, and VSCode does this for editor tabs. However, webviews do not intercept these keystrokes.

If a webview such as Release Notes or Markdown Preview has focus:

- when the user presses Ctrl+N, another instance of the PWA is opened in a new window.
- when the user presses Ctrl+W, the whole PWA window closes.

See microsoft#150735 for details.

This fixes the issue by ignoring Ctrl+W and Ctrl+N in webviews.

Tested on macOS 12.6 / Chrome Dev 109.0.5384.0:

- patch environmentService.ts webviewExternalEndpoint to use
  http://localhost:8080/static/sources/out/vs/workbench/contrib/webview/browser/pre/
- followed the contributing instruction to run code-web
- in Chrome, More Tools -> Create Shortcut -> Open as window
- closed and re-opened Code OSS PWA window
- opened chrome://inspect and inspected the Code OSS window
- added an uncaught exception handler
- opened file.md and chose "Open preview"
- when it hit
  `Expected '${parentOriginHash}' as hostname or subdomain!`
  manually ran `start(parentOrigin)` in console and continued
- the markdown preview now displayed
- pressed Command+W

Before: the whole window closes
After: only the Markdown preview tab closes

* Prompt users to test with extensions disabled (microsoft#165203)

* Pick up TS 4.9 rc for bundled VS Code version (microsoft#165205)

* don't create and dispose submenus (microsoft#165206)

fixes microsoft#161413

* Remove notebook content provider api (microsoft#165195)

Fixes microsoft#160580
Fixes microsoft#147248

* Notebook find widget and toolbar css variable.

* Cell comments css variables

* Typo: folding controller. (microsoft#165211)

* Don't clear the pause reason for other threads when processing a stopped event with allThreadsStopped=true (microsoft#165180)

Fix microsoft#165032

* Diff overview ruler css variables

* Reduce theme participant for notebook diff editor

* use ID for quick fix telemetry (microsoft#165197)

* Fix KaTeX equation numbering in notebook preview (microsoft#156276)

Fixes microsoft#155888

* cleanup ipc integration tests (microsoft#165221)

* more test cleanup (microsoft#165233)

* Switch to using CSS (microsoft#165185)

* Switch to using CSS

* Better fallback value

* adopt `vscode.l10n` in references view (microsoft#165245)

microsoft#164438

* report perf marks whenever delivered (microsoft#165250)

* Nit: fix Tip blocks case (microsoft#165223)

* Fix some cases of incremental naming disabled (microsoft#165253)

* Let opener service validate that only specific commands can be run in command uris (microsoft#165204)

* Save all dirty editors before storing edit session (microsoft#165246)

* don't set quick pick items every time value changes (microsoft#165113)

* Fix autoreveal on file nest (microsoft#165272)

* skip resolve (without backup) test (microsoft#165277)

* TestInstantiationService in fileDialogService.test.ts (microsoft#165270)

Part of microsoft#164297

* Duplicating Menu Actions when switching profiles (microsoft#165274)

Fixes microsoft#161910

* Fix microsoft#164690 microsoft#164730 (microsoft#165279)

- Maintain default installed extensions manifest always
- Adopt to default installed extensions manifest
- Add externally installed extension to default extensions manifest

* Remove ianhu from team github issue notebooks (microsoft#165281)

* remove ianhu from team github issue notebooks

* revert accidental line end change

Co-authored-by: Ian Huff <ianhuff@Ians-MacBook-Pro.local>

* tweak quick pick pin conditional (microsoft#165285)

tweak conditional

* Update quick pick placeholders and/or remove titles (microsoft#165267)

* Use ?. for property access (microsoft#165295)

* Bump targets for test/automation and test/integration (microsoft#165298)

Also enables strict mode for test/integration since it only had strict null checks previously

* Revert "Fix microsoft#164690 microsoft#164730 (microsoft#165279)" (microsoft#165302)

* Reduce usage of invalid property overrides (microsoft#165293)

With native property fields, a few of our properties are no longer valid. This either removes them or switches them to use declare instead

* Enable strict mode and bump target for test/smoke (microsoft#165296)

* Move notebook editor widget theme to css variables (microsoft#165300)

* Fixes microsoft#165238 (microsoft#165242)

* Fix microsoft#164690 microsoft#164730 (microsoft#165331)

* Revert "Revert "Fix microsoft#164690 microsoft#164730 (microsoft#165279)" (microsoft#165302)"

This reverts commit d9ed6d1.

* store migration completion marker in profile

* joh/external marlin (microsoft#165336)

* move typeHierarchyPeek onto CSS variables

* move symbolIcons onto CSS variables

* move markerHoverParticipant onto CSS variables

* starting timings (perf machine) shouldn't complain about missing cached data (microsoft#165342)

* combine all origin selection ranges when having multiple go-to via mouse result (microsoft#165349)

fixes microsoft#160958

* stricter definition for what a trival snippet it (microsoft#165355)

fixes microsoft#163808

* Align cache key across OSes (microsoft#165042)

* Attempt to fix Rust clippy lint errors (microsoft#165377)

* Reduce loaded web modules (microsoft#165369)

* Partially reverts 1b83b96 (microsoft#165372)

Partially reverts microsoft@1b83b96

* Implement Add "Ignore" buttons microsoft#164425 (microsoft#165387)

* Fix renderHeight being undefined (microsoft#165373)

* Git - Remove localization from askpass-main (microsoft#165129)

Remove localization from askpass as it runs in a separate process

* Fix tasks status incorrect microsoft#163393 (microsoft#163952)

* Fix arrows in side-by-side diff view

* Reduce unused exports, ref microsoft#164939 (microsoft#165389)

* last folding range not restored (microsoft#165390)

* last folding range not restored

* Update src/vs/editor/contrib/folding/browser/foldingRanges.ts

Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com>

* Update src/vs/editor/contrib/folding/browser/foldingRanges.ts

Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com>

* Update src/vs/editor/contrib/folding/browser/foldingRanges.ts

Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com>

Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com>

* proper check for WCO (microsoft#165384)

fixes microsoft#165337

* eslint: add a new rule to enforce `declare _serviceBrand: undefined` (microsoft#165396)

* debt: move or remove `NullXYZServices` (microsoft#165397)

We have a few NullXYZServices. Those are useful for testing but we should move them to separate files so that we don't end up shipping them with the product

* Fixes `Terminal: Focus Terminal Tabs view` command not working (microsoft#164408)

* Remove redundant CSS rules (microsoft#165401)

Ref microsoft#165169
Ref microsoft#157564

After changing workspace trust and policy settings
to use indicators, a bunch of CSS rules became redundant.
This PR removes those CSS rules.

* Contributed activity's busy icon fails to display after resetting containing TreeView's badge state (microsoft#165255)

Fixes microsoft#165181

* Bump target for build scripts (microsoft#165287)

* Refactor settingsWidgets (microsoft#165412)

* WIP Change Settings editor CSS to variables

* Refactor settingsWidgets

* remove unused exports (microsoft#165411)

task part of microsoft#164933

* Improve file dialog action button (microsoft#165417)

* Improve file dialog action button

* `Location` -> `Destination`

* adopt CSS variables in terminal (microsoft#165419)

* Improve command center hover colors (microsoft#165427)

Improve command center hover interaction

* keybindingLabel: switch theming to css variables (microsoft#165426)

* use the actual extension id as the id in the language pack (microsoft#165436)

Past behavior caused 404s to be thrown by the unpkg service because core was trying to load:

`${extensionId}` -> `vscode.markdown`

and not what the build creates in the language packs:
`vscode.${extensionFolder}` -> `vscode.markdown-basics`

this aligns build time and runtime.

* Use CSS variables for settingsTree.ts (microsoft#165437)

Ref microsoft#165169

* Add accessibility role type to the checkbox in getting started step

* Add typings for webview messages (microsoft#165446)

* fix microsoft#165434 (microsoft#165440)

* Adopt l10n for markdown extension (microsoft#165448)

For microsoft#164438

Also makes our eslint rules understand `vscode.l10n.t(`

* Adopt l10n for ts extension (microsoft#165450)

For microsoft#164438

Also refines the eslint rule from microsoft#165448

* Git - Add "OK, Don't Ask Again" button to the publish branch prompt (microsoft#165487)

Add "OK, Don't Ask Again" button to the publish branch prompt

* support updating installed extensions (microsoft#165485)

* support updating installed extensions
when installed externally (cli, manual)

* 💄

* refactor

* Git - Optimistic UI plumbing (microsoft#165237)

* Reduce unused exports (microsoft#165494)

* do not set appication extensions location for default profile (microsoft#165496)

* Progressbar: Use css variables for styling (microsoft#165503)

Progressbar: Use css variables for styling (for microsoft#165478)

* Also make button focusable

* Fix typings issues with TestInstantiationService microsoft#164297 (microsoft#165514)

* Comment view filtering: incorrect count (Showing x of y) (microsoft#165517)

Fixes microsoft#165444

* better error message

* Fix microsoft#165410. No css variables defined at root. (microsoft#165519)

* Adopt  l10n for configuration-editing (microsoft#165521)

For microsoft#164438

* Remove overzealous telemetry (microsoft#165524)

* Adopt l10n for media-preview (microsoft#165525)

For microsoft#164438

* Adopt l10n for simple-browser (microsoft#165529)

For microsoft#164438

* Adopt l10n for merge-conflict (microsoft#165531)

For microsoft#164438

* Skip debug tree error in telemetry (microsoft#165535)

Fix microsoft#164053

* Move some keybinding editor colours to CSS (microsoft#165537)

Ref microsoft#165169

* Adopt l10n for extension-editing (microsoft#165523)

For microsoft#164438

* Fix microsoft#165480 (microsoft#165486)

* Adopt l10n for jake (microsoft#165541)

For microsoft#164438

* More logs around SecretStorage (microsoft#165542)

* Adopt l10n for gulp (microsoft#165543)

For microsoft#164438

* Comment widget doesn't work with inline diffs on deleted lines (microsoft#165547)

Fixes microsoft#164729

* Try to sort console history entries in recency order (microsoft#165549)

Fix microsoft#148072

* Adopt l10n for grunt and php-language-features (microsoft#165552)

* Adopt l10n for grunt

For microsoft#164438

* Adopt l10n for php-language-features

For microsoft#164438

* Adopt l10n for npm package (microsoft#165527)

For microsoft#164438

* Fix UI string (microsoft#165554)

* add task section to terminal dropdown (microsoft#165553)

* Update role and aria-label for the Hide button in the Welcome View  (microsoft#165505)

Update role and aria-label for the Hide button

* Checkbox is hard to see in dark mode on selected file change node in tree view (microsoft#165556)

Fixes microsoft#163881

* don't show title bar context on cmd (microsoft#165557)

fixes microsoft#165545

* Remove executePrimary and notebookEditor proposal (microsoft#165532)

Fix microsoft#164505

* treat editor tab ctrl+click as right click (microsoft#165558)

fixes microsoft#160413

* Use css variables for editor scrollbar (microsoft#165464)

Co-authored-by: gcb4 <gcb4@sfu.ca>

* check if a task run is in progress before running it  (microsoft#165560)

* Pick up latest TS for building VS Code (microsoft#165562)

* Refactor sash hover border to use CSS var (microsoft#165516)

Ref microsoft#165169

* adopt css var in lieu of registerThemingParticipant (microsoft#165561)

* panel and auxiliar bar part css
refs microsoft#165169

* unused imports

* Increase min-height to 100% (microsoft#165566)

Fixes microsoft#165518

* Move list of trusted extensions to product.json & enable for Desktop (microsoft#165565)

Fixes https://github.com/microsoft/vscode-internalbacklog/issues/3161

It's wild to me that we only allowed this on web originally. This should get rid of quite a few dialogs on Desktop.

* Localize emmet using l10n.t (microsoft#165568)

Ref microsoft#164438

* run auto tasks if trusted & on  (microsoft#165570)

* Try passing offset to editors on layout (microsoft#164287)

* Try passing offset to editors on layout

When a notebook editor is created, it currently has to force a relayout to determine where the overlay webview should be positioned. We do this with a call to `getBoundingClientRect`

However the grid view should already have information about where the editor is positioned. If we can use this, then we can skip the expensive call to `getBoundingClientRect` entirely

This change attempts to pass the `top` and `left` offsets to the `EditorGroupView` and eventually down into `NotebookEditorWidget`

The PR does not work properly however as the offset that the `EditorGroupView` gets is wrong. I've added some todo comments about where this seems to be happening

* Remove todo and update layout over

* Git - Only use `this.dotGit` when resolving HEAD (microsoft#165497)

Fix microsoft#164363

Co-authored-by: Johannes <johannes.rieken@gmail.com>
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
Co-authored-by: Sandeep Somavarapu <sasomava@microsoft.com>
Co-authored-by: Logan Ramos <lramos15@gmail.com>
Co-authored-by: Alex Ross <alros@microsoft.com>
Co-authored-by: Rob Lourens <roblourens@gmail.com>
Co-authored-by: Peng Lyu <penn.lv@gmail.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
Co-authored-by: Matt Bierner <matb@microsoft.com>
Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
Co-authored-by: Joyce Er <joyce.er@microsoft.com>
Co-authored-by: Henning Dieterichs <notify.henning.dieterichs@live.de>
Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com>
Co-authored-by: gjsjohnmurray <johnm@georgejames.com>
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com>
Co-authored-by: David Dossett <ddossett@microsoft.com>
Co-authored-by: João Moreno <joao.moreno@microsoft.com>
Co-authored-by: Henning Dieterichs <hdieterichs@microsoft.com>
Co-authored-by: Megan Rogge <merogge@microsoft.com>
Co-authored-by: SteVen Batten <6561887+sbatten@users.noreply.github.com>
Co-authored-by: Andrea Mah <31675041+andreamah@users.noreply.github.com>
Co-authored-by: Jason Williams <936006+jasonwilliams@users.noreply.github.com>
Co-authored-by: Christof Marti <chrmarti@microsoft.com>
Co-authored-by: Takafumi Umemoto <takafumi.umemoto@gmail.com>
Co-authored-by: Jean Pierre <jeanp413@hotmail.com>
Co-authored-by: Isidor Nikolic <inikolic@microsoft.com>
Co-authored-by: Andre Weinand <aweinand@microsoft.com>
Co-authored-by: Hugh Lilly <hughlilly@users.noreply.github.com>
Co-authored-by: zhuowei <zhuoweizhang@yahoo.com>
Co-authored-by: Peng Lyu <penlv@microsoft.com>
Co-authored-by: Ping <5123601+pingren@users.noreply.github.com>
Co-authored-by: SphinxKnight <SphinxKnight@users.noreply.github.com>
Co-authored-by: Ian Huff <ianhu@microsoft.com>
Co-authored-by: Ian Huff <ianhuff@Ians-MacBook-Pro.local>
Co-authored-by: Huiwen <huiwen@gitpod.io>
Co-authored-by: Mingpan <mingpanguo@gmail.com>
Co-authored-by: Bhavya Udayashankar <bhavyau@microsoft.com>
Co-authored-by: aamunger <aamunger@microsoft.com>
Co-authored-by: pafernandez-oesia <96843912+pafernandez-oesia@users.noreply.github.com>
Co-authored-by: Gaurav Bhagchandani <gbolosta@gmail.com>
Co-authored-by: gcb4 <gcb4@sfu.ca>
@chrmarti
Copy link
Contributor

chrmarti commented Nov 30, 2022

Still seeing this with v0.55.2022113009:

Error: No tree view with id 'github:compareChanges' registered.
    at f.$getChildren (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:115:11908)
    at u.N (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:104:11208)
    at u.M (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:104:10926)
    at u.H (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:104:10019)
    at u.G (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:104:9157)
    at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:104:7788
    at d.invoke (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:63:145)
    at w.deliver (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:63:2029)
    at g.fire (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:63:1667)
    at h.fire (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:72:14314)
    at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:120:15804
    at d.invoke (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:63:145)
    at w.deliver (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:63:2029)
    at g.fire (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:63:1667)
    at h.fire (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:72:14314)
    at MessagePortMain.<anonymous> (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:120:13960)
    at MessagePortMain.emit (node:events:526:28)
    at Object.MessagePortMain._internalPort.emit (node:electron/js2c/utility_init:5:364)

@onionhammer
Copy link

See this popup every single time

@redlinejoes
Copy link

Still happening in v0.56.0.
"No tree view with id 'github:compareChanges' registered." after opening PR.

@alexr00
Copy link
Member

alexr00 commented Jan 13, 2023

The fix is in VS Code insiders.

@rzhao271 rzhao271 added the verified Verification succeeded label Jan 26, 2023
@neoOpus
Copy link

neoOpus commented Mar 9, 2023

The fix is in VS Code insiders.

I have this version and got the error

Version: 1.76.0 (user setup)
Commit: 92da9481c0904c6adfe372c12da3b7748d74bdcb
Date: 2023-03-01T10:22:44.506Z
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: 10.2.154.26-electron.0
OS: Windows_NT x64 10.0.25309
Sandboxed: Yes

@alexr00 alexr00 reopened this Mar 9, 2023
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug and removed bug Issue identified by VS Code Team member as probable bug verified Verification succeeded labels Mar 9, 2023
@alexr00 alexr00 modified the milestones: January 2023, April 2023 Mar 9, 2023
@rubensa
Copy link

rubensa commented Mar 15, 2023

Same problem here, using VSCode Dev Containers extension v0.282.0 (docker container).

GitHub Pull Requests and Issues v0.60.0

Version: 1.76.1
Commit: 5e805b79fcb6ba4c2d23712967df89a089da575b
Date: 2023-03-08T16:31:31.010Z
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: 10.2.154.26-electron.0
OS: Linux x64 5.19.0-35-generic
Sandboxed: No
[[object Object]]ENOENT: no such file or directory, lstat '/workspaces/project/.github/workflows/markdown-checker.yml.git'
$onExtensionRuntimeError @ mainThreadExtensionService.ts:79
Error: ENOENT: no such file or directory, lstat '/workspaces/project/.github/workflows/markdown-checker.yml.git'
	at Object.lstatSync (node:fs:1516:3)
	at c (/home/user/.vscode-server/extensions/redhat.vscode-yaml-1.12.1/dist/extension.js:2:284766)
	at /home/user/.vscode-server/extensions/redhat.vscode-yaml-1.12.1/dist/extension.js:2:285125
	at f.invoke (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:145)
	at m.deliver (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:2066)
	at d.fire (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:1704)
	at /vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:98:9669
	at f.invoke (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:145)
	at m.deliver (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:2066)
	at d.fire (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:1704)
	at m.acceptDocumentsAndEditorsDelta (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:98:13808)
	at m.$acceptDocumentsAndEditorsDelta (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:98:12249)
	at a.N (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:106:11223)
	at a.M (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:106:10941)
	at a.H (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:106:10034)
	at a.G (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:106:9015)
	at /vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:106:7803
	at f.invoke (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:145)
	at m.deliver (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:2066)
	at d.fire (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:1704)
	at p.fire (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:72:14907)
	at /vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:122:16556
	at f.invoke (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:145)
	at m.deliver (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:2066)
	at d.fire (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:1704)
	at p.fire (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:72:14907)
	at t.E (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:72:18973)
	at /vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:72:16961
	at f.invoke (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:145)
	at m.deliver (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:2066)
	at d.fire (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:1704)
	at u.acceptChunk (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:72:12638)
	at /vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:72:11925
	at f.invoke (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:145)
	at m.deliver (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:2066)
	at d.fire (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:1704)
	at d.u (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:72:28911)
	at d.acceptFrame (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:72:28717)
	at f.l (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:72:27304)
	at /vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:72:24627
	at Socket.t (/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:72:22461)
	at Socket.emit (node:events:526:28)
	at addChunk (node:internal/streams/readable:315:12)
	at readableAddChunk (node:internal/streams/readable:289:9)
	at Socket.Readable.push (node:internal/streams/readable:228:10)
	at TCP.onStreamRead (node:internal/stream_base_commons:190:23)
Error: No tree view with id 'github:compareChanges' registered.
	at m.$getChildren (vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:117:11887)
	at a.N (vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:106:11223)
	at a.M (vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:106:10941)
	at a.H (vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:106:10034)
	at a.G (vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:106:9172)
	at vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:106:7803
	at f.invoke (vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:145)
	at m.deliver (vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:2066)
	at d.fire (vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:1704)
	at p.fire (vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:72:14907)
	at vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:122:16556
	at f.invoke (vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:145)
	at m.deliver (vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:2066)
	at d.fire (vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:1704)
	at p.fire (vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:72:14907)
	at t.E (vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:72:18973)
	at vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:72:16961
	at f.invoke (vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:145)
	at m.deliver (vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:2066)
	at d.fire (vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:1704)
	at u.acceptChunk (vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:72:12638)
	at vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:72:11925
	at f.invoke (vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:145)
	at m.deliver (vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:2066)
	at d.fire (vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:63:1704)
	at d.u (vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:72:28911)
	at d.acceptFrame (vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:72:28717)
	at f.l (vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:72:27304)
	at vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:72:24627
	at Socket.t (vscode-file://vscode-app/vscode/vscode-server/bin/linux-x64/5e805b79fcb6ba4c2d23712967df89a089da575b/out/vs/workbench/api/node/extensionHostProcess.js:72:22461)
	at Socket.emit (node:events:526:28)
	at addChunk (node:internal/streams/readable:315:12)
	at readableAddChunk (node:internal/streams/readable:289:9)
	at Socket.Readable.push (node:internal/streams/readable:228:10)
	at TCP.onStreamRead (node:internal/stream_base_commons:190:23)
c @ notificationsAlerts.ts:40

@mjbvz mjbvz added the verified Verification succeeded label Apr 27, 2023
daniel-wachira added a commit to trilogy-group/openvscode-server that referenced this issue Jul 6, 2023
* cli: add new control server messages for wsl (microsoft#180438)

* cli: add new control server messages for wsl

* support cwd in spawn

* use auth session id for sync when enabled by embedder (microsoft#180444)

* add plan-items to release notes section (microsoft#180445)

* Oops

* Render both debug frame indicator and breakpoint (microsoft#180448)

* clean up extension recommendations (microsoft#180450)

* clean up extension recommendations

* retain editor config extension

* Add API that exposes interactive session provider name (microsoft#180437)

* Add API that exposes interactive session provider name

* Update command label

* Suppress default text drop if there's also a uri list (microsoft#180452)

* Support markdown string

* Fix search result count again (microsoft#180453)

* Add comment

* Allow description map to be optional

* Add extension based tests

* Fix test

* Try

* Use custom node-gyp for SDL pipeline (microsoft#179723)

* Use custom node-gyp
* Avoid using relative cd
* Remove ia32 for Linux
* Bump gulp-atom-electron; unblocks downloading PDBs
* Add native-is-elevated to the scan

* Allow new codeblock actions to be shown at the top level of the toolbar (microsoft#180460)

* Make description optional when reading storage

* debug session: use queue to make sure debugee status get processed in correct order (microsoft#180410)

Similarly to fed69ad, this adds a queue to serialize the processing
of pause/continue events. Without this, if a pause and continue events
are sent really fast, the pause handler will take longer to process than
the continue handler and the state of the debugger UI will be paused
when the debuggee is actually running.

Fixes microsoft#180409

* No more raw IPC in the Issue Reporter (microsoft#180449)

This is the initial implementation of the issue reporter no longer having raw IPC calls in it.

I think there's plenty more to clean up, but this is a start...

cc @bpasero

cc @Tyriar if you wanna do this for the process explorer

* fix run selected text

* Fix Interactive Session widget role (microsoft#180463)

Fix Interactive Session widget

* cleanup save API (microsoft#180476)

* Revert "add accessibility verbosity settings for terminal and diff editor aria hints" (microsoft#180477)

* changed the weight to workbench contrib

* cancel code lens resolve requests when document is being edited (microsoft#180485)

https://github.com/microsoft/vscode-internalbacklog/issues/3884

* show commands only when having reply, proper type for different edit modes

* Fixes microsoft#3928 (microsoft#180404)

* Fixes microsoft#3928

* Fixes CI

* [debt] extract Session object which holds useful state for commands

* Fixes microsoft#153754. (microsoft#180490)

* Fixes microsoft#153754.

* Fixes microsoft#159479

* allow for default sash ratio in diff editor (side-by-side) and use it for inline diff'ing

* Fixes microsoft#173495 (microsoft#180492)

* Fix no tree view error when view is disposed during refresh (microsoft#180415)

Fixes microsoft/vscode-pull-request-github#4002

* add missing monaco.d.ts file

* Remove comments when a comment provider is unregistered (microsoft#180502)

Fixes microsoft/vscode-pull-request-github#4566

* Observed deriveds are now recomputed lazily. (microsoft#180487)

* Observed deriveds are now recomputed lazily.

* Fixes CI

* Fixes observable bug

* Fixes microsoft#173209 (microsoft#180505)

* Fixes accept next word bug

* Fixes microsoft#173209

* Don't dispose model in separate transactions, as deriveds are now computed lazily. (microsoft#180507)

* Fixes microsoft#180224 (microsoft#180511)

* in notebooks cancel inline chat sessions from sibling editors when starting a new session (microsoft#180509)

https://github.com/microsoft/vscode-internalbacklog/issues/3897

* extension host - allow to veto stopping (microsoft#179224) (microsoft#180513)

* changing the code so that view in chat is an additional button in the toolbar and the text appears below the toolbar

* adding the context key while waiting for the merge

* changing the css

* Improve selected row checkbox style (microsoft#180515)

Fixes microsoft#180506

* cleanup preview styles and keep status bar consistent (microsoft#180518)

* add `CTX_INTERACTIVE_EDITOR_LAST_RESPONSE_TYPE` and use that to control visiblity accept, cancel, and toggle inline action (microsoft#180517)

* add `CTX_INTERACTIVE_EDITOR_LAST_RESPONSE_TYPE` and use that to control visiblity accept, cancel, and toggle inline action

* fix compile errors

* cleaning the code

* cleaning the code

* Add command for expanding unresolved comments (microsoft#180521)

Fixes microsoft#169928

* adopt tunnel mutex name change (microsoft#180524)

* chore: update electron@22.4.8 (microsoft#180526)

* joh/passive barracuda (microsoft#180530)

* tweak inline diff editor options, make sure livePreview and notebooks is pretty

* tweak logging

* handle 403 and bail out immediately (microsoft#180547)

* Also wait for user data init

* wait only when init is required

* make sure rename disposes it `EditorStateCancellationTokenSource` so that its down-level context key is correctly updated (microsoft#180545)

this is part two of https://github.com/microsoft/vscode-internalbacklog/issues/3928

* Don't run chat codeblocks in task terminals (microsoft#180552)

* Add command/keybinding to change drop type (microsoft#180556)

* Add command/keybinding to change drop type

Adds a command/keybinding to toggle the post drop widget

* Also show keybinding

* Code review

* Fix drop widget having transparent background on hover (microsoft#180562)

We now overlay the button-secondaryHoverBackground over editor-widgetBackground

* Update distro

* Oops

* Iios

* Re microsoft#178715. Wait for notebook model to be ready for dispose (microsoft#180560)

* remove unnecessary ? (microsoft#180564)

* ensure focus is set correctly in output, enable keyboard scrolling for outputs

* report telemetry (microsoft#180567)

* Instrument Microsoft account type (microsoft#180573)

So we can see if folks are using MSA or AAD accounts. Also, this cleans up some dead code.

Fixes https://github.com/microsoft/vscode-internalbacklog/issues/3903

* Specify codeActionKinds (microsoft#180576)

Avoids extra calls and lets us show this info in the UI

* Also search injected text decorations tree for margin decorations (microsoft#180620)

* Also search injected text decorations tree for margin decorations

* Simplify fix

* quick access - allow a `Promise<FastAndSlowPicks<T>>` and adopt for commands (microsoft#180664)

* quick access - allow a `Promise<FastAndSlowPicks<T>>` and adopt for commands

* fix telemetry

* Change the way the InteractiveSessionModel is loaded into the widget (microsoft#180668)

* Change the way the InteractiveSessionModel is loaded into the widget
And the way viewState is managed. Fixes a bunch of general issues with this flow between views and editors

* Fix reloading editor after clear

* don't terminate IE session when observing outside edits (microsoft#180680)

Only when they earase everything cancel IE session, otherwise just live with it

* hide ghost text when invoking IE session (microsoft#180682)

https://github.com/microsoft/vscode-internalbacklog/issues/3573

* Fixes microsoft#180222 (microsoft#180681)

* Fixes microsoft#180538 (microsoft#180683)

* Fixes microsoft#180489 (microsoft#180684)

* add jsdoc comment for trackFocus (microsoft#180690)

* work in propgress, adding the fix for the feedback bug also

* Show hover message for diff revert arrow (microsoft#180378)

* fixes microsoft#177444 (microsoft#180704)

* prioritize images over text in accessiblity mode

* Fix microsoft#180588 (microsoft#180708)

* fix microsoft#180670

* cleaning the code

* split out event propagation handling

* using the toggle functionality instead

* pre saving the old data

* use editor options

* polishing the code

* remove true

* Allow negative numbers for `go to match` (microsoft#180479)

Fixes microsoft#180475

Also fixes the case where there are zero matches, which previously resulted in a non-functional quick input

* Pick up latest TS for building VS code (microsoft#180706)

* SCM - ActionBar rendering optimization (microsoft#180712)

* SCM - ActionBar rendering optimization

* address PR comments

---------

Co-authored-by: João Moreno <joao.moreno@microsoft.com>

* add some padding to MD message, restore right alignment of status label

* show accept/discard btns even when last response was a message response

* check the scroll height of the correct element

* Use readonly editor instead of an untitled buffer when showing environment changes

* Use view state to restore InteractiveSessionViewPane session by id (microsoft#180732)

* remove escape to container hotkey

* Organize Errors in GitHub Auth and make sure no double prompting happens (microsoft#180734)

* Organize Errors in GitHub Auth and make sure no double prompting happens

This mostly just moves some strings into variables... but this also fixes the GH Auth side of microsoft#180697 so you should only be asked once if you want to try a different way to log in.

* add comments

* Initial support for notebook CodeActions (microsoft#180740)

* support cmd codeActions on nb save

* add setting

* rm comment

* add log + add await command

* missed a space in setting description

* Improves observable docs

* fix class selection query

* fix message formatting

* fix: Double pasting in webview(using russian keyboard layout) (microsoft#161001) (microsoft#178120)

Co-authored-by: Matt Bierner <matb@microsoft.com>

* Use custom command to open JS doc links (microsoft#180737)

Fixes microsoft#162507

Prevents incorrect auto transform of the uri

* testing: tie test output correctly to runs, rework ui accordingly (microsoft#180746)

* testing: don't enqueue tests into tasks that are created

This is an old artifact that caused problems in the issue this fixes microsoft#180041

When we get a new 'task' from a test run request, we automatically
marked all tests as being enqueued with it. However, tests are now lazily
added to the test run states, so this would only affect tests that
_already_ had their state set to something (e.g. in another task). And
therefore it was also ineffective for its original purpose of marking
all included tests as being Queued, since extensions have had to do that
themselves anyway.

So just remove this code! Also, adjust priorities such that "skipped"
priorities are shown above unset ones.

* testing: tie test output correctly to runs, rework ui accordingly

Previously, test output was handled for an entire TestRunRequest into
a single stream. This didn't match what the public API implied, nor what
the real intentions were.

This makes output be stored correctly on a per-test run (called "tasks"
internally). It changes the order of the Test Results view so that tests
nested under their task, and also improves some of the tree handling
there to update nodes more specifically.

Clicking on the "terminal" button in the test view continues to show
output from the last test run request, but if there were multiple tasks,
the user is asked to choose which they want to view output for.

Finally I removed some old unused code that dealt with storing test
results on disk, which we no longer do, and moved to a simpler interface
instead.

Fixes microsoft#180041

* Apply buffer copy optimization to `updateOutput` oto (microsoft#180755)

For microsoft#168142

Follow up on 9fd77b4. Applies the same optimization to `updateOutput` as well

* Restore welcome message when restoring chat session (microsoft#180756)

* Change the shape of persisted sessions

* Also backup sessions that were not restored in this window

* Restore welcome message when restoring chat session

* add F20-F24 key support for keyboard shortcuts

* remove unused keyCodeOrd from key mappings list

* Feed 📓 error to interactive session. (microsoft#180766)

* Add command to show chat session history (microsoft#180770)

* testing: avoid including individual children in run at cursor if their parent is already included (microsoft#180763)

For #180760

* Add maximum number of persisted chat sessions (microsoft#180775)

* fix microsoft#180721

* build: quieter node module cache logging (microsoft#180709)

* Default Themes: Rename Experimental to Dark Modern (microsoft#180785)

Default Themes: Rename Experimental to Modern

* Merge user port changes with extension forwarded ports (microsoft#180694)

* Merge user port changes with extension forwards

* Actually add port to unrestoredExtensionTunnels

* nit

* context keys: fix: add serialize() support for ContextKeyNotRegexExpr

Fixes microsoft#180012

* update third party notices (microsoft#180788)

* Update ThirdPartyNotices.txt

* update distro

* new default theme: check setting when patching initial colors (microsoft#180687)

* new default theme: check setting when patching initial colors

* remove unneeded imports

* json/css/html: update dependencies (microsoft#180714)

* json/css/html: update dependencies

* update services

* add nls message to preserve link syntax (microsoft#180821)

* add lint rule to prevent type discrimination properties in API types (microsoft#180829)

re microsoft#63943 and other

* remove nb.codeactiononsave setting, add `nb.experimental` to command ID

* update wording

* cli: fix problem restarting tunnel with uppercase letter in name (microsoft#180881)

Fixes microsoft#180693

* Fix drop mime type wildcard regexp (microsoft#180883)

For microsoft#180878

* Disable breakpoint hint when a test loading icon is present (microsoft#180884)

* Add extra notes on `files` drop mime type (microsoft#180886)

Fixes microsoft#180878

* Fix enumItem labels (microsoft#180889)

`javascript.preferences.importModuleSpecifierEnding` and `typescript.preferences.importModuleSpecifierEnding` got out of sync here

* Fix markdown settings localization (microsoft#180891)

The syntax backtick hash str hash backtick was getting mangled.... but it probably should be extracted out so translators don't have the potential for changing it.

* Bump distro (microsoft#180895)

* Fix microsoft#180797. Fine tune edit mode switch. (microsoft#180900)

Fix microsoft#180797.

* Update terminal status even if it is already present

* Fix microsoft#180857. Empty cmd+f should not unset search keyword. (microsoft#180901)

* Fix microsoft#180861. Cell stays in editing mode if it is not modified by find. (microsoft#180902)

* API 💄 (microsoft#180911)

* more cursor overrides: style and blinking

fixes https://github.com/microsoft/vscode-internalbacklog/issues/3864

* making the css selectable by changing the css file

* make sure to restore diff editor focus after repositioning the zone widget

fixes https://github.com/microsoft/vscode-internalbacklog/issues/3964

* back to `computeHumanReadableDiff` diff

fixes https://github.com/microsoft/vscode-internalbacklog/issues/3962

* simplify code for demo (microsoft#180932)

* disable inline completions for inline chat input

fixes https://github.com/microsoft/vscode-internalbacklog/issues/3961

* disabe cmd/ctrl+z for "special undo" of inline chat

fixes https://github.com/microsoft/vscode-internalbacklog/issues/3966

* don't show release notes on web (microsoft#180937)

fixes microsoft#179536

* Fix initial comment expand state (microsoft#180941)

Fixes microsoft#169928

* prevent endless autoSend loop of inline chat (microsoft#180945)

fixes https://github.com/microsoft/vscode-internalbacklog/issues/3990

* "Show Next Change" doesn't show the right change (microsoft#180951)

Fixes microsoft#180744

* make sure EditModeStrategy#apply/cancel isn't called twice, keep reference onto editor model to prevent dispose before reset (microsoft#180952)

fixes https://github.com/microsoft/vscode-internalbacklog/issues/3963

* Enables experiments for diffEditor.diffAlgorithm (microsoft#180954)

* update distro (microsoft#180953)

* Fix typo in vscode.d.ts (microsoft#177377)

"of" -> "or"

Co-authored-by: Matt Bierner <matb@microsoft.com>

* fix multi range formatting (microsoft#180955)

fixes microsoft#178825

* update distro (microsoft#180957)

* Fix microsoft#177405. Treat error as plain text. (microsoft#180960)

* Fix microsoft#180290. Tweak wording accurately for install/enable missing extension. (microsoft#180961)

* Fix microsoft#163383 (microsoft#180963)

* Fix copying a suggested followup question in chat (microsoft#180965)

* add workspaceTrust to nb "codeaction" infra (microsoft#180968)

* Fix Issue Reporter API (microsoft#180971)

* Fix Issue Reporter API

CancellationTokens aren't hydrated over ProxyChannels so I've removed cancellation logic.

Additionally, there was a bad string compare that needed toLower when checking if an extension has a handler.

Additionally, added docs.

Fixes microsoft#180890
Fixes microsoft#180920
Fixes microsoft#180887

* remove import

* remove another import

* [json] update service (microsoft#180972)

* fix microsoft#180899

* Notification marker color turns grey when selected (microsoft#180973)

* Add mode to the notification (microsoft#180977)

ref microsoft#180803 (comment)

* Add overrideCategory back (microsoft#180975)

* Update getting started theme picker images to reflect new themes (microsoft#180976)

* Update getting started theme picker assets to reflect new themes

* Update theme names

* Fixes bug in observable utility

* Fixes microsoft#180792

* Fixes CI

* Update vscode.d.ts for clearSessionPreference (microsoft#180979)

Fixes microsoft#180860

* Use a colon instead of quotes to handle long queries better (microsoft#180980)

Fixes https://github.com/microsoft/vscode-internalbacklog/issues/4021

* fix microsoft#172465

* undo some changes

* Allow clicking to remove breakpoint even alongside non debug decorations (microsoft#180986)

* Load chat username/icon from current session, not persisted data (microsoft#180981)

* update distro (microsoft#180992)

* Avoid double encoding vscode.dev links (microsoft#181002)

* Fixes microsoft#181007 (microsoft#181008)

* Fixes microsoft#181009 (microsoft#181011)

* Fixes microsoft#181009

* Use isMeasurement: true for boolean

* Use correct key for hybrid port unforwarding (microsoft#181005)

* Use correct key for hybrid port unforwarding

* Use forwarded host for closing

* Delete key from this.autoForwarded

* Adds telemetry to understand how long the diff editor was visible to the user. (microsoft#181021)

* Adds telemetry to understand how long the diff editor was visible to the user.

* Uses StopWatch utility.

* Fixes CI

* 💄

* 💄

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>

* enable live preview for last line of document. for that... (microsoft#181029)

- support `ordinal` and `showInHiddenAreas` for `IViewZone`
- adopt in zoneWidget
- adopt for inline chat widgets
- remove code that isn't needed anymore 👯‍♂️

fixes https://github.com/microsoft/vscode-internalbacklog/issues/4024

* fix microsoft#175014

* fix tab order for hidden status element when a message shows

fixes https://github.com/microsoft/vscode-internalbacklog/issues/4039

* don't use role or aria-label attributes so that contents get read out

fixes https://github.com/microsoft/vscode-internalbacklog/issues/4035

* Add a couple teammates to my-endgame notebook (microsoft#181059)

* Add a couple teammates to my-endgame notebook

friends :)

* Add @Yoyokrazy

* Add @paulacamargo25

* debug: bump js-debug (microsoft#181049)

Fixes microsoft#181047

* Revert "Fix: diff editor arrow click enables breakpoint " (microsoft#181040)

* Set glyph margin decoration width appropriately (microsoft#181071)

* Move opening default built-in walkthrough to after built-in walkthrough initialization (microsoft#181066)

* chore: bump distro (microsoft#181104)

* Unexpected theme name showing up in web (microsoft#181091)

* Unexpected theme name showing up in web

* incorperate feedback

* Install extension in the right server (microsoft#181110)

* Fixes `PieceTreeBase.equal` (microsoft#181125)

Fixes `PieceTreeBase.equal` (fixes microsoft/vscode-internalbacklog#4025)

* Revert "Fixes `PieceTreeBase.equal` (microsoft#181125)" (microsoft#181270)

This reverts commit 3862229.

* cli: tunnels can sporadically become unresponsive (microsoft#181286)

Last iteration I moved some RPC logic to use Tokios "codecs" to give
them cancellation safety. These operate on streams of input data.

While this worked at first, I failed to take into account that the byte
buffer we read from the stream could have _more_ data than just the
current message under load scenarios. We were discarding any extra data
from the subsequent message. In most cases caused the next message
"length" to be read from the middle of the next message, which usually
(when parsed as a u32) was some number of gigabytes, then causing the
connection to stall forever.

Fixes microsoft#181284

* Add temporary nodeJS walkthrough (microsoft#181442)

* bump version

* unc - adopt setting and handling of allow list (gitpod-io#5)

* unc - adopt setting and handling of allow list

* unc - set allow list on server too

* unc - pick our patched node.js for now

* bump electron

* unc - ignore sync is not needed with machine scope

* unc - use process set directly

* 🆙 22.5.1

* code web server initial commit

* Don't test the Feedback component

* enable prebuilds for all branches

* Add example guide for pre-installing vscode extensions with docker installation

* 💄

* Update deprecated example in README 

Option 'connection-secret' is deprecated: Use connection-token-file instead.

* Fix default image destroyed in merge

* Port the delayed signal patch to gp-code-1.78

* Fix build

* Remove access token requirement as we're running in a sandbox

* Revert "Remove access token requirement as we're running in a sandbox"

This reverts commit 8a7a90c.
Use the --without-connection-token arg instead

---------

Co-authored-by: Connor Peet <connor@peet.io>
Co-authored-by: Sandeep Somavarapu <sasomava@microsoft.com>
Co-authored-by: First <karraj@microsoft.com>
Co-authored-by: Joyce Er <joyce.er@microsoft.com>
Co-authored-by: Rob Lourens <roblourens@gmail.com>
Co-authored-by: Matt Bierner <matb@microsoft.com>
Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
Co-authored-by: Florent Revest <revestflo@gmail.com>
Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com>
Co-authored-by: Megan Rogge <merogge@microsoft.com>
Co-authored-by: Johannes Rieken <johannes.rieken@gmail.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
Co-authored-by: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Co-authored-by: Henning Dieterichs <hdieterichs@microsoft.com>
Co-authored-by: Alex Ross <alros@microsoft.com>
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Peng Lyu <penn.lv@gmail.com>
Co-authored-by: aamunger <aamunger@microsoft.com>
Co-authored-by: João Moreno <joao.moreno@microsoft.com>
Co-authored-by: meganrogge <megan.rogge@microsoft.com>
Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com>
Co-authored-by: Michael Lively <milively@microsoft.com>
Co-authored-by: dongfang <wb.yindongfang@mesg.corp.netease.com>
Co-authored-by: Ilia Pozdnyakov <ilia.pozdnyakov@ya.ru>
Co-authored-by: Ulugbek Abdullaev <ulugbekna@gmail.com>
Co-authored-by: Lakshya A Agrawal <lakshya18242@iiitd.ac.in>
Co-authored-by: Bhavya U <bhavyau@microsoft.com>
Co-authored-by: David Dossett <ddossett@microsoft.com>
Co-authored-by: SteVen Batten <steven.m.batten@outlook.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
Co-authored-by: Filip Troníček <filip@gitpod.io>
Co-authored-by: Anton Kosyakov <anton@gitpod.io>
Co-authored-by: AXON <axonasif@gmail.com>
Co-authored-by: Jean Pierre <jeanp413@hotmail.com>
Co-authored-by: Bjarne Sievers <jellyfishcoding@live.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
10 participants