Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump code to 1.78 #2

Merged
merged 10,000 commits into from
Jul 6, 2023
Merged

Bump code to 1.78 #2

merged 10,000 commits into from
Jul 6, 2023

Conversation

daniel-wachira
Copy link
Collaborator

@daniel-wachira daniel-wachira commented May 12, 2023

Merge into upstream release 1.78

connor4312 and others added 30 commits April 20, 2023 15:19
* cli: add new control server messages for wsl

* support cwd in spawn
* clean up extension recommendations

* retain editor config extension
)

* Add API that exposes interactive session provider name

* Update command label
* Use custom node-gyp
* Avoid using relative cd
* Remove ia32 for Linux
* Bump gulp-atom-electron; unblocks downloading PDBs
* Add native-is-elevated to the scan
… correct order (microsoft#180410)

Similarly to fed69ad, this adds a queue to serialize the processing
of pause/continue events. Without this, if a pause and continue events
are sent really fast, the pause handler will take longer to process than
the continue handler and the state of the debugger UI will be paused
when the debuggee is actually running.

Fixes microsoft#180409
This is the initial implementation of the issue reporter no longer having raw IPC calls in it.

I think there's plenty more to clean up, but this is a start...

cc @bpasero

cc @Tyriar if you wanna do this for the process explorer
meganrogge and others added 22 commits April 27, 2023 13:20
don't use role or aria-label attributes so that contents get read out
* Unexpected theme name showing up in web

* incorperate feedback
Last iteration I moved some RPC logic to use Tokios "codecs" to give
them cancellation safety. These operate on streams of input data.

While this worked at first, I failed to take into account that the byte
buffer we read from the stream could have _more_ data than just the
current message under load scenarios. We were discarding any extra data
from the subsequent message. In most cases caused the next message
"length" to be read from the middle of the next message, which usually
(when parsed as a u32) was some number of gigabytes, then causing the
connection to stall forever.

Fixes microsoft#181284
* unc - adopt setting and handling of allow list

* unc - set allow list on server too

* unc - pick our patched node.js for now

* bump electron

* unc - ignore sync is not needed with machine scope

* unc - use process set directly

* 🆙 22.5.1
Option 'connection-secret' is deprecated: Use connection-token-file instead.
@daniel-wachira
Copy link
Collaborator Author

We can ignore the yarn.lock check failure. I've already verified that this builds ok with our build scripts.

This reverts commit 8a7a90c.
Use the --without-connection-token arg instead
@daniel-wachira daniel-wachira merged commit a8df5de into main Jul 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.