testing: add a test results panel #175414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, as in the issue this fixes #175377, messages without location were treated a little strangely, and messages for tests without a location were impossible to view. Them transient nature of the peek has been a longstanding overall experience papercut. This PR adds a Test Results panel which users can keep around as a persistent results view. It shares the code used to generate the peek view. With this PR, I've also tweaked it slightly so that the test 'history' is by default (unless toggled on) shown only in the panel, aligning the test errors peek more towards the diagnostics view, where the peek is a lighter, local view, and the panel shows everything. The only real 'addition' to the previously-peek content in this PR is that test output is shown when the top-level run node is selected. _Ideally_ this would be in a terminal where full ANSI codes and colors are supported, but it seems terminal land does not support this very well, and I want to eventually get ANSI color support in text mode anyway (#151964).
alexdima
approved these changes
Feb 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, as in the issue this fixes #175377, messages without location were treated a little strangely, and messages for tests without a location in either were impossible to view. Them transient nature of the peek has been a longstanding overall experience papercut.
This PR adds a Test Results panel which users can keep around as a persistent results view. It shares the code used to generate the peek view. With this PR, I've also tweaked it slightly so that the test 'history' is by default (unless toggled on) shown only in the panel, aligning the test errors peek more towards the diagnostics view, where the peek is a lighter, local view, and the panel shows everything.
The only real 'addition' to the previously-peek content in this PR is that test output is shown when the top-level run node is selected. Ideally this would be in a terminal where full ANSI codes and colors are supported, but it seems terminal land does not support this very well, and I want to eventually get ANSI color support in text mode anyway (#151964).